Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-notch.html

Issue 2667153002: Convert BiquadFilter response tests to testharness (Closed)
Patch Set: Address review comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-notch.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-notch.html b/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-notch.html
index 21dfe0f6aacd4ff36efdfe12cf2477175c549bc7..f0ed46db052202946922ba30f1ba613e36cfe78a 100644
--- a/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-notch.html
+++ b/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-notch.html
@@ -2,29 +2,21 @@
<html>
<head>
-<script src="../../resources/js-test.js"></script>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
<script src="../resources/audit-util.js"></script>
-<script src="../resources/audio-testing.js"></script>
+<script src="../resources/audit.js"></script>
<script src="../resources/biquad-filters.js"></script>
<script src="../resources/biquad-testing.js"></script>
</head>
<body>
+<script>
+let audit = Audit.createTaskRunner();
-<div id="description"></div>
-<div id="console"></div>
+audit.define("test", function (task, should) {
+ task.describe("Biquad notch filter");
-<script>
-description("Tests Biquad notch filter.");
-
-function runTest() {
- if (window.testRunner) {
- testRunner.dumpAsText();
- testRunner.waitUntilDone();
- }
-
- window.jsTestIsAsync = true;
-
// Create offline audio context.
var context = new OfflineAudioContext(2, sampleRate * renderLengthSeconds, sampleRate);
@@ -35,14 +27,13 @@ function runTest() {
];
createTestAndRun(context, "notch", {
+ should: should,
threshold: 1.9669e-8,
filterParameters: filterParameters
- });
-}
-
-runTest();
-successfullyParsed = true;
+ }).then(task.done.bind(task));
+});
+audit.run();
</script>
</body>

Powered by Google App Engine
This is Rietveld 408576698