The CQ bit was checked by aberent@chromium.org
Created Revert of Use new app-level object instantiation mechanism
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1485872881075850, "parent_rev": "2bd09f395bbc0b2b30f5b4801358decf4223e690", "commit_rev": "a4b96272c745c096c11b55f4f7a33b3d1b766101"}
Description was changed from ========== Revert of Use new app-level object instantiation mechanism (patchset #3 id:40001 of https://codereview.chromium.org/2652383002/ ) Reason for revert: This causes Clank to crash on startup (consistently). BUG=687142 Original issue's description: > Use new app-level object instantiation mechanism > > This change uses a new mechanism for instantiating objects from the > Chrome application for several classes. > > BUG=685383 > > Review-Url: https://codereview.chromium.org/2652383002 > Cr-Commit-Position: refs/heads/master@{#447078} > Committed: https://chromium.googlesource.com/chromium/src/+/f77ebec0c7db165ee6039e617432... TBR=mariakhomenko@chromium.org,cco3@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=685383 ========== to ========== Revert of Use new app-level object instantiation mechanism (patchset #3 id:40001 of https://codereview.chromium.org/2652383002/ ) Reason for revert: This causes Clank to crash on startup (consistently). BUG=687142 Original issue's description: > Use new app-level object instantiation mechanism > > This change uses a new mechanism for instantiating objects from the > Chrome application for several classes. > > BUG=685383 > > Review-Url: https://codereview.chromium.org/2652383002 > Cr-Commit-Position: refs/heads/master@{#447078} > Committed: https://chromium.googlesource.com/chromium/src/+/f77ebec0c7db165ee6039e617432... TBR=mariakhomenko@chromium.org,cco3@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=685383 Review-Url: https://codereview.chromium.org/2666913002 Cr-Commit-Position: refs/heads/master@{#447230} Committed: https://chromium.googlesource.com/chromium/src/+/a4b96272c745c096c11b55f4f7a3... ==========
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a4b96272c745c096c11b55f4f7a3...