Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1348)

Issue 2666913002: Revert of Use new app-level object instantiation mechanism (Closed)

Created:
3 years, 10 months ago by aberent
Modified:
3 years, 10 months ago
Reviewers:
cco3, Maria
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, agrieve+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use new app-level object instantiation mechanism (patchset #3 id:40001 of https://codereview.chromium.org/2652383002/ ) Reason for revert: This causes Clank to crash on startup (consistently). BUG=687142 Original issue's description: > Use new app-level object instantiation mechanism > > This change uses a new mechanism for instantiating objects from the > Chrome application for several classes. > > BUG=685383 > > Review-Url: https://codereview.chromium.org/2652383002 > Cr-Commit-Position: refs/heads/master@{#447078} > Committed: https://chromium.googlesource.com/chromium/src/+/f77ebec0c7db165ee6039e617432faa12c436641 TBR=mariakhomenko@chromium.org,cco3@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=685383 Review-Url: https://codereview.chromium.org/2666913002 Cr-Commit-Position: refs/heads/master@{#447230} Committed: https://chromium.googlesource.com/chromium/src/+/a4b96272c745c096c11b55f4f7a33b3d1b766101

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -14 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivitySessionTracker.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 4 chunks +70 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/externalauth/ExternalAuthUtils.java View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAServiceClient.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/help/HelpAndFeedback.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBleClient.java View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebEnvironment.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
aberent
Created Revert of Use new app-level object instantiation mechanism
3 years, 10 months ago (2017-01-31 14:28:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666913002/1
3 years, 10 months ago (2017-01-31 14:28:10 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 14:29:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a4b96272c745c096c11b55f4f7a3...

Powered by Google App Engine
This is Rietveld 408576698