Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2652383002: Use new app-level object instantiation mechanism (Closed)

Created:
3 years, 11 months ago by cco3
Modified:
3 years, 10 months ago
Reviewers:
Maria
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, agrieve+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use new app-level object instantiation mechanism This change uses a new mechanism for instantiating objects from the Chrome application for several classes. BUG=685383 Review-Url: https://codereview.chromium.org/2652383002 Cr-Commit-Position: refs/heads/master@{#447078} Committed: https://chromium.googlesource.com/chromium/src/+/f77ebec0c7db165ee6039e617432faa12c436641

Patch Set 1 #

Patch Set 2 : Remove RevenueStats change #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -96 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivitySessionTracker.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 1 2 5 chunks +0 lines, -70 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/externalauth/ExternalAuthUtils.java View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAServiceClient.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/help/HelpAndFeedback.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBleClient.java View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebEnvironment.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
cco3
Note: this depends on https://codereview.chromium.org/2655463008/
3 years, 11 months ago (2017-01-26 00:29:46 UTC) #2
Maria
lgtm -- I assume you'll rebase this after other CLs land
3 years, 11 months ago (2017-01-27 04:42:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652383002/40001
3 years, 10 months ago (2017-01-30 21:07:58 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/f77ebec0c7db165ee6039e617432faa12c436641
3 years, 10 months ago (2017-01-30 21:49:16 UTC) #9
aberent
3 years, 10 months ago (2017-01-31 14:28:00 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2666913002/ by aberent@chromium.org.

The reason for reverting is: This causes Clank to crash on startup
(consistently).

BUG=687142.

Powered by Google App Engine
This is Rietveld 408576698