Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2666873005: Implement aria-modal (Closed)

Created:
3 years, 10 months ago by dmazzoni
Modified:
3 years, 10 months ago
Reviewers:
aboxhall, pfeldman
CC:
chromium-reviews, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, kinuko+watch, caseq+blink_chromium.org, aboxhall, aboxhall+watch_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, je_julie, einbinder+watch-test-runner_chromium.org, devtools-reviews_chromium.org, blink-reviews, blink-reviews-api_chromium.org, yuzo+watch_chromium.org, dmazzoni, lushnikov+blink_chromium.org, haraken, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, nektar+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, dtseng+watch_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement aria-modal This is the Blink part of the implementation, with tests. It adds an isModal interface to accessible objects, and implements it for both aria-modal, and for HTML dialogs. The Chromium part of the implementation will follow. BUG=644766 Review-Url: https://codereview.chromium.org/2666873005 Cr-Commit-Position: refs/heads/master@{#447712} Committed: https://chromium.googlesource.com/chromium/src/+/1e45f35b6aafa2a42782065192a37e778f0e6d24

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+414 lines, -2 lines) Patch
M components/test_runner/web_ax_object_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/test_runner/web_ax_object_proxy.cc View 2 chunks +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/accessibility/aria-modal.html View 1 chunk +66 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodesModal-expected.txt View 1 chunk +9 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-modal.html View 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-modal-expected.txt View 1 chunk +259 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAttributeNames.in View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebAXObject.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebAXObject.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
dmazzoni
3 years, 10 months ago (2017-01-31 23:19:46 UTC) #3
aboxhall
lgtm
3 years, 10 months ago (2017-01-31 23:42:12 UTC) #6
pfeldman
lgtm
3 years, 10 months ago (2017-02-02 01:41:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666873005/1
3 years, 10 months ago (2017-02-02 04:21:32 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 06:41:58 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1e45f35b6aafa2a42782065192a3...

Powered by Google App Engine
This is Rietveld 408576698