Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

Issue 2666873005: Implement aria-modal (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp b/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
index 8df32816daf20dec44c87d1fd64e831e489eaf02..4ef4a5fa86e2a93091d1a13905c5583b8fcd0837 100644
--- a/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
@@ -115,6 +115,10 @@ void fillGlobalStates(AXObject& axObject,
}
}
+bool roleAllowsModal(AccessibilityRole role) {
+ return role == DialogRole || role == AlertDialogRole;
+}
+
bool roleAllowsMultiselectable(AccessibilityRole role) {
return role == GridRole || role == ListBoxRole || role == TabListRole ||
role == TreeGridRole || role == TreeRole;
@@ -306,6 +310,11 @@ void fillWidgetStates(AXObject& axObject,
createProperty(AXWidgetStatesEnum::Selected,
createBooleanValue(axObject.isSelected())));
}
+
+ if (roleAllowsModal(role)) {
+ properties.addItem(createProperty(AXWidgetStatesEnum::Modal,
+ createBooleanValue(axObject.isModal())));
+ }
}
std::unique_ptr<AXProperty> createRelatedNodeListProperty(
« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXObject.h ('k') | third_party/WebKit/Source/web/WebAXObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698