Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: components/autofill/content/renderer/autofill_agent.cc

Issue 2666873004: Do not hide the "Login Not Secure" warning on keystrokes (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/content/renderer/autofill_agent.h" 5 #include "components/autofill/content/renderer/autofill_agent.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <tuple> 9 #include <tuple>
10 10
(...skipping 560 matching lines...) Expand 10 before | Expand all | Expand 10 after
571 options.autofill_on_empty_values = true; 571 options.autofill_on_empty_values = true;
572 options.show_full_suggestion_list = true; 572 options.show_full_suggestion_list = true;
573 for (auto element : elements) 573 for (auto element : elements)
574 ShowSuggestions(element, options); 574 ShowSuggestions(element, options);
575 } 575 }
576 576
577 void AutofillAgent::ShowNotSecureWarning( 577 void AutofillAgent::ShowNotSecureWarning(
578 const blink::WebInputElement& element) { 578 const blink::WebInputElement& element) {
579 if (is_generation_popup_possibly_visible_) 579 if (is_generation_popup_possibly_visible_)
580 return; 580 return;
581 HidePopup();
582 password_autofill_agent_->ShowNotSecureWarning(element); 581 password_autofill_agent_->ShowNotSecureWarning(element);
583 is_popup_possibly_visible_ = true; 582 is_popup_possibly_visible_ = true;
584 } 583 }
585 584
586 void AutofillAgent::OnSamePageNavigationCompleted() { 585 void AutofillAgent::OnSamePageNavigationCompleted() {
587 if (last_interacted_form_.isNull()) { 586 if (last_interacted_form_.isNull()) {
588 // If no last interacted form is available (i.e., there is no form tag), 587 // If no last interacted form is available (i.e., there is no form tag),
589 // we check if all the elements the user has interacted with are gone, 588 // we check if all the elements the user has interacted with are gone,
590 // to decide if submission has occurred. 589 // to decide if submission has occurred.
591 if (formless_elements_user_edited_.size() == 0 || 590 if (formless_elements_user_edited_.size() == 0 ||
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
822 void AutofillAgent::LegacyAutofillAgent::OnDestruct() { 821 void AutofillAgent::LegacyAutofillAgent::OnDestruct() {
823 // No-op. Don't delete |this|. 822 // No-op. Don't delete |this|.
824 } 823 }
825 824
826 void AutofillAgent::LegacyAutofillAgent::FocusChangeComplete() { 825 void AutofillAgent::LegacyAutofillAgent::FocusChangeComplete() {
827 if (agent_) 826 if (agent_)
828 agent_->FocusChangeComplete(); 827 agent_->FocusChangeComplete();
829 } 828 }
830 829
831 } // namespace autofill 830 } // namespace autofill
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698