Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2666833004: Delete app jit or aot snapshots as each test is completed to reduce the amount of disk space requir… (Closed)

Created:
3 years, 10 months ago by rmacnak
Modified:
3 years, 10 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Delete app jit or aot snapshots as each test is completed to reduce the amount of disk space required to run the test suite. R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/302e54a55d077f47192a5a62142e636f524b6462

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Patch Set 3 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -30 lines) Patch
M tools/testing/dart/compiler_configuration.dart View 2 chunks +3 lines, -23 lines 0 comments Download
M tools/testing/dart/runtime_configuration.dart View 1 2 2 chunks +18 lines, -7 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 1 2 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
3 years, 10 months ago (2017-02-01 01:59:09 UTC) #2
Bill Hesse
LGTM https://codereview.chromium.org/2666833004/diff/1/tools/testing/dart/runtime_configuration.dart File tools/testing/dart/runtime_configuration.dart (right): https://codereview.chromium.org/2666833004/diff/1/tools/testing/dart/runtime_configuration.dart#newcode240 tools/testing/dart/runtime_configuration.dart:240: List commands = new List(); var commands = ...
3 years, 10 months ago (2017-02-01 02:07:44 UTC) #3
rmacnak
Committed patchset #3 (id:40001) manually as 302e54a55d077f47192a5a62142e636f524b6462 (presubmit successful).
3 years, 10 months ago (2017-02-01 17:20:55 UTC) #5
rmacnak
3 years, 10 months ago (2017-02-01 17:21:12 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/2666833004/diff/1/tools/testing/dart/runtime_...
File tools/testing/dart/runtime_configuration.dart (right):

https://codereview.chromium.org/2666833004/diff/1/tools/testing/dart/runtime_...
tools/testing/dart/runtime_configuration.dart:240: List commands = new List();
On 2017/02/01 02:07:44, Bill Hesse wrote:
> var commands = new List<Command>();
> or
> var command = new <Command>[];
> would be better for strong mode, I think.

Done.

Powered by Google App Engine
This is Rietveld 408576698