Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: tools/testing/dart/compiler_configuration.dart

Issue 2666833004: Delete app jit or aot snapshots as each test is completed to reduce the amount of disk space requir… (Closed)
Patch Set: review Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/dart/runtime_configuration.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/compiler_configuration.dart
diff --git a/tools/testing/dart/compiler_configuration.dart b/tools/testing/dart/compiler_configuration.dart
index 4b5be7d19e9a3911d971ee5d6734e9be0cda6277..830f4401a1a83676040486518bc657745ca3b958 100644
--- a/tools/testing/dart/compiler_configuration.dart
+++ b/tools/testing/dart/compiler_configuration.dart
@@ -609,8 +609,9 @@ class PrecompilerCompilerConfiguration extends CompilerConfiguration {
if (!useBlobs) {
commands.add(this.computeAssembleCommand(tempDir, buildDir, CommandBuilder.instance,
arguments, environmentOverrides));
- commands.add(this.computeRemoveAssemblyCommand(tempDir, buildDir,
- CommandBuilder.instance, arguments, environmentOverrides));
+ // This step reduces the amount of space needed to run the precompilation
+ // tests by 60%.
+ commands.add(commandBuilder.getDeleteCommand("$tempDir/out.S"));
}
return new CommandArtifact(commands, '$tempDir', 'application/dart-precompiled');
}
@@ -697,27 +698,6 @@ class PrecompilerCompilerConfiguration extends CompilerConfiguration {
bootstrapDependencies(buildDir), exec, args, environmentOverrides);
}
- // This step reduces the amount of space needed to run the precompilation
- // tests by 60%.
- CompilationCommand computeRemoveAssemblyCommand(
- String tempDir,
- String buildDir,
- CommandBuilder commandBuilder,
- List arguments,
- Map<String, String> environmentOverrides) {
- var exec = 'rm';
- var args = ['$tempDir/out.S'];
-
- return commandBuilder.getCompilationCommand(
- 'remove_assembly',
- tempDir,
- !useSdk,
- bootstrapDependencies(buildDir),
- exec,
- args,
- environmentOverrides);
- }
-
List<String> filterVmOptions(List<String> vmOptions) {
var filtered = new List.from(vmOptions);
filtered.removeWhere(
« no previous file with comments | « no previous file | tools/testing/dart/runtime_configuration.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698