Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Side by Side Diff: tools/testing/dart/compiler_configuration.dart

Issue 2666833004: Delete app jit or aot snapshots as each test is completed to reduce the amount of disk space requir… (Closed)
Patch Set: review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/testing/dart/runtime_configuration.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library compiler_configuration; 5 library compiler_configuration;
6 6
7 import 'dart:io' show Platform; 7 import 'dart:io' show Platform;
8 8
9 import 'runtime_configuration.dart' show RuntimeConfiguration; 9 import 'runtime_configuration.dart' show RuntimeConfiguration;
10 import 'runtime_configuration.dart' show DartPrecompiledAdbRuntimeConfiguration; 10 import 'runtime_configuration.dart' show DartPrecompiledAdbRuntimeConfiguration;
(...skipping 591 matching lines...) Expand 10 before | Expand all | Expand 10 after
602 String tempDir, 602 String tempDir,
603 CommandBuilder commandBuilder, 603 CommandBuilder commandBuilder,
604 List arguments, 604 List arguments,
605 Map<String, String> environmentOverrides) { 605 Map<String, String> environmentOverrides) {
606 var commands = new List<Command>(); 606 var commands = new List<Command>();
607 commands.add(this.computeCompilationCommand(tempDir, buildDir, CommandBuilde r.instance, 607 commands.add(this.computeCompilationCommand(tempDir, buildDir, CommandBuilde r.instance,
608 arguments, environmentOverrides)); 608 arguments, environmentOverrides));
609 if (!useBlobs) { 609 if (!useBlobs) {
610 commands.add(this.computeAssembleCommand(tempDir, buildDir, CommandBuilder .instance, 610 commands.add(this.computeAssembleCommand(tempDir, buildDir, CommandBuilder .instance,
611 arguments, environmentOverrides)); 611 arguments, environmentOverrides));
612 commands.add(this.computeRemoveAssemblyCommand(tempDir, buildDir, 612 // This step reduces the amount of space needed to run the precompilation
613 CommandBuilder.instance, arguments, environmentOverrides)); 613 // tests by 60%.
614 commands.add(commandBuilder.getDeleteCommand("$tempDir/out.S"));
614 } 615 }
615 return new CommandArtifact(commands, '$tempDir', 'application/dart-precompil ed'); 616 return new CommandArtifact(commands, '$tempDir', 'application/dart-precompil ed');
616 } 617 }
617 618
618 CompilationCommand computeCompilationCommand( 619 CompilationCommand computeCompilationCommand(
619 String tempDir, 620 String tempDir,
620 String buildDir, 621 String buildDir,
621 CommandBuilder commandBuilder, 622 CommandBuilder commandBuilder,
622 List arguments, 623 List arguments,
623 Map<String, String> environmentOverrides) { 624 Map<String, String> environmentOverrides) {
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
690 args.addAll([ 691 args.addAll([
691 '-o', 692 '-o',
692 '$tempDir/out.aotsnapshot', 693 '$tempDir/out.aotsnapshot',
693 '$tempDir/out.S' 694 '$tempDir/out.S'
694 ]); 695 ]);
695 696
696 return commandBuilder.getCompilationCommand('assemble', tempDir, !useSdk, 697 return commandBuilder.getCompilationCommand('assemble', tempDir, !useSdk,
697 bootstrapDependencies(buildDir), exec, args, environmentOverrides); 698 bootstrapDependencies(buildDir), exec, args, environmentOverrides);
698 } 699 }
699 700
700 // This step reduces the amount of space needed to run the precompilation
701 // tests by 60%.
702 CompilationCommand computeRemoveAssemblyCommand(
703 String tempDir,
704 String buildDir,
705 CommandBuilder commandBuilder,
706 List arguments,
707 Map<String, String> environmentOverrides) {
708 var exec = 'rm';
709 var args = ['$tempDir/out.S'];
710
711 return commandBuilder.getCompilationCommand(
712 'remove_assembly',
713 tempDir,
714 !useSdk,
715 bootstrapDependencies(buildDir),
716 exec,
717 args,
718 environmentOverrides);
719 }
720
721 List<String> filterVmOptions(List<String> vmOptions) { 701 List<String> filterVmOptions(List<String> vmOptions) {
722 var filtered = new List.from(vmOptions); 702 var filtered = new List.from(vmOptions);
723 filtered.removeWhere( 703 filtered.removeWhere(
724 (option) => option.startsWith("--optimization-counter-threshold")); 704 (option) => option.startsWith("--optimization-counter-threshold"));
725 filtered.removeWhere( 705 filtered.removeWhere(
726 (option) => option.startsWith("--optimization_counter_threshold")); 706 (option) => option.startsWith("--optimization_counter_threshold"));
727 return filtered; 707 return filtered;
728 } 708 }
729 709
730 List<String> computeCompilerArguments( 710 List<String> computeCompilerArguments(
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
914 RuntimeConfiguration runtimeConfiguration, 894 RuntimeConfiguration runtimeConfiguration,
915 String buildDir, 895 String buildDir,
916 TestInformation info, 896 TestInformation info,
917 List<String> vmOptions, 897 List<String> vmOptions,
918 List<String> sharedOptions, 898 List<String> sharedOptions,
919 List<String> originalArguments, 899 List<String> originalArguments,
920 CommandArtifact artifact) { 900 CommandArtifact artifact) {
921 return <String>[]; 901 return <String>[];
922 } 902 }
923 } 903 }
OLDNEW
« no previous file with comments | « no previous file | tools/testing/dart/runtime_configuration.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698