Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2666823003: 📰 Remove the NTPSuggestionsFetchMore feature flag (Closed)

Created:
3 years, 10 months ago by dgn
Modified:
3 years, 10 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Client] Remove the NTPSuggestionsFetchMore feature flag BUG=667752 Review-Url: https://codereview.chromium.org/2666823003 Cr-Commit-Position: refs/heads/master@{#447498} Committed: https://chromium.googlesource.com/chromium/src/+/54d36fe6918e83360b6a60963a90e2884805d789

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M components/ntp_snippets/features.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/ntp_snippets/features.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/ntp_snippets/remote/json_request.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestions_fetcher.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (10 generated)
dgn
PTAL. The dependent CL merges the fetch_more and reload flags in category_info
3 years, 10 months ago (2017-02-01 10:28:15 UTC) #7
Marc Treib
lgtm Awesome!
3 years, 10 months ago (2017-02-01 10:30:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666823003/1
3 years, 10 months ago (2017-02-01 13:12:18 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 13:16:37 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/54d36fe6918e83360b6a60963a90...

Powered by Google App Engine
This is Rietveld 408576698