Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Side by Side Diff: components/ntp_snippets/features.cc

Issue 2666823003: 📰 Remove the NTPSuggestionsFetchMore feature flag (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/ntp_snippets/features.h ('k') | components/ntp_snippets/remote/json_request.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/ntp_snippets/features.h" 5 #include "components/ntp_snippets/features.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/time/clock.h" 8 #include "base/time/clock.h"
9 #include "components/ntp_snippets/category_rankers/click_based_category_ranker.h " 9 #include "components/ntp_snippets/category_rankers/click_based_category_ranker.h "
10 #include "components/ntp_snippets/category_rankers/constant_category_ranker.h" 10 #include "components/ntp_snippets/category_rankers/constant_category_ranker.h"
(...skipping 24 matching lines...) Expand all
35 35
36 const base::Feature kContentSuggestionsSource{ 36 const base::Feature kContentSuggestionsSource{
37 "NTPSnippets", base::FEATURE_ENABLED_BY_DEFAULT}; 37 "NTPSnippets", base::FEATURE_ENABLED_BY_DEFAULT};
38 38
39 const base::Feature kSectionDismissalFeature{ 39 const base::Feature kSectionDismissalFeature{
40 "NTPSuggestionsSectionDismissal", base::FEATURE_ENABLED_BY_DEFAULT}; 40 "NTPSuggestionsSectionDismissal", base::FEATURE_ENABLED_BY_DEFAULT};
41 41
42 const base::Feature kForeignSessionsSuggestionsFeature{ 42 const base::Feature kForeignSessionsSuggestionsFeature{
43 "NTPForeignSessionsSuggestions", base::FEATURE_DISABLED_BY_DEFAULT}; 43 "NTPForeignSessionsSuggestions", base::FEATURE_DISABLED_BY_DEFAULT};
44 44
45 const base::Feature kFetchMoreFeature{"NTPSuggestionsFetchMore",
46 base::FEATURE_ENABLED_BY_DEFAULT};
47
48 const base::Feature kPreferAmpUrlsFeature{"NTPPreferAmpUrls", 45 const base::Feature kPreferAmpUrlsFeature{"NTPPreferAmpUrls",
49 base::FEATURE_ENABLED_BY_DEFAULT}; 46 base::FEATURE_ENABLED_BY_DEFAULT};
50 47
51 const base::Feature kCategoryRanker{"ContentSuggestionsCategoryRanker", 48 const base::Feature kCategoryRanker{"ContentSuggestionsCategoryRanker",
52 base::FEATURE_ENABLED_BY_DEFAULT}; 49 base::FEATURE_ENABLED_BY_DEFAULT};
53 50
54 const char kCategoryRankerParameter[] = "category_ranker"; 51 const char kCategoryRankerParameter[] = "category_ranker";
55 const char kCategoryRankerConstantRanker[] = "constant"; 52 const char kCategoryRankerConstantRanker[] = "constant";
56 const char kCategoryRankerClickBasedRanker[] = "click_based"; 53 const char kCategoryRankerClickBasedRanker[] = "click_based";
57 54
(...skipping 29 matching lines...) Expand all
87 return base::MakeUnique<ClickBasedCategoryRanker>(pref_service, 84 return base::MakeUnique<ClickBasedCategoryRanker>(pref_service,
88 std::move(clock)); 85 std::move(clock));
89 default: 86 default:
90 NOTREACHED() << "The category ranker choice value is " 87 NOTREACHED() << "The category ranker choice value is "
91 << static_cast<int>(choice); 88 << static_cast<int>(choice);
92 } 89 }
93 return nullptr; 90 return nullptr;
94 } 91 }
95 92
96 } // namespace ntp_snippets 93 } // namespace ntp_snippets
OLDNEW
« no previous file with comments | « components/ntp_snippets/features.h ('k') | components/ntp_snippets/remote/json_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698