Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2666663002: Avoid double layout for writing mode roots if LayoutNG is enabled (Closed)

Created:
3 years, 10 months ago by Gleb Lanbin
Modified:
3 years, 10 months ago
Reviewers:
kojii, eae
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid double layout for writing mode roots if LayoutNG is enabled In legacy code we perform a series of subtree layouts that can be avoided in LayoutNG code. This patch disables layoutOrthogonalWritingModeRoots if layoutNG is enabled. BUG=635619 Review-Url: https://codereview.chromium.org/2666663002 Cr-Commit-Position: refs/heads/master@{#447083} Committed: https://chromium.googlesource.com/chromium/src/+/8772b878183be72d544d3f9d0267b9255e1f1f98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Gleb Lanbin
3 years, 10 months ago (2017-01-30 19:30:11 UTC) #2
kojii
non-owner lgtm, thank you. +eae
3 years, 10 months ago (2017-01-30 19:42:13 UTC) #4
eae
LGTM
3 years, 10 months ago (2017-01-30 19:45:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666663002/1
3 years, 10 months ago (2017-01-30 19:47:47 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 22:05:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8772b878183be72d544d3f9d0267...

Powered by Google App Engine
This is Rietveld 408576698