Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2666663002: Avoid double layout for writing mode roots if LayoutNG is enabled (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1074 matching lines...) Expand 10 before | Expand all | Expand 10 after
1085 layoutFromRootObject(*root); 1085 layoutFromRootObject(*root);
1086 1086
1087 // We need to ensure that we mark up all layoutObjects up to the 1087 // We need to ensure that we mark up all layoutObjects up to the
1088 // LayoutView for paint invalidation. This simplifies our code as we just 1088 // LayoutView for paint invalidation. This simplifies our code as we just
1089 // always do a full tree walk. 1089 // always do a full tree walk.
1090 if (LayoutItem container = LayoutItem(root->container())) 1090 if (LayoutItem container = LayoutItem(root->container()))
1091 container.setMayNeedPaintInvalidation(); 1091 container.setMayNeedPaintInvalidation();
1092 } 1092 }
1093 m_layoutSubtreeRootList.clear(); 1093 m_layoutSubtreeRootList.clear();
1094 } else { 1094 } else {
1095 if (hasOrthogonalWritingModeRoots()) 1095 if (hasOrthogonalWritingModeRoots() &&
1096 !RuntimeEnabledFeatures::layoutNGEnabled())
1096 layoutOrthogonalWritingModeRoots(); 1097 layoutOrthogonalWritingModeRoots();
1097 layoutFromRootObject(*layoutView()); 1098 layoutFromRootObject(*layoutView());
1098 } 1099 }
1099 1100
1100 m_frame->document()->fetcher()->updateAllImageResourcePriorities(); 1101 m_frame->document()->fetcher()->updateAllImageResourcePriorities();
1101 1102
1102 lifecycle().advanceTo(DocumentLifecycle::AfterPerformLayout); 1103 lifecycle().advanceTo(DocumentLifecycle::AfterPerformLayout);
1103 1104
1104 TRACE_EVENT_END1(PERFORM_LAYOUT_TRACE_CATEGORIES, "FrameView::performLayout", 1105 TRACE_EVENT_END1(PERFORM_LAYOUT_TRACE_CATEGORIES, "FrameView::performLayout",
1105 "counters", analyzerCounters()); 1106 "counters", analyzerCounters());
(...skipping 3955 matching lines...) Expand 10 before | Expand all | Expand 10 after
5061 std::unique_ptr<CompositorAnimationTimeline> timeline) { 5062 std::unique_ptr<CompositorAnimationTimeline> timeline) {
5062 m_animationTimeline = std::move(timeline); 5063 m_animationTimeline = std::move(timeline);
5063 } 5064 }
5064 5065
5065 void FrameView::setAnimationHost( 5066 void FrameView::setAnimationHost(
5066 std::unique_ptr<CompositorAnimationHost> host) { 5067 std::unique_ptr<CompositorAnimationHost> host) {
5067 m_animationHost = std::move(host); 5068 m_animationHost = std::move(host);
5068 } 5069 }
5069 5070
5070 } // namespace blink 5071 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698