Make headless_shell target compile for Windows

Make headless_shell target compile for Windows:
- Add necessary configs so exec file can be compiled
- Enable logging options (this is enforced in windows, otherwise logging path will fail with DCHECK)
- Change screenshot file writing to use file_proxy, since file_stream does not work properly in linux: it's harcoded
to use message_loop_io to do the write, which does not work in Windows since the the FileThread is attached to the ui message loop
- Adds special rules in devtools code generation scripts to avoid collision with windows specific macros (like ERR)
- Changes the way the command line is parsed so its compatible with Windows
- Modify headless.gn args to be compatible with windows also.
- And some nits under #if defined(OS_WIN)


BUG=686608
Review-Url: https://codereview.chromium.org/2666503002
Cr-Commit-Position: refs/heads/master@{#449906}
Committed: https://chromium.googlesource.com/chromium/src/+/79dd3437b6e5dddaafeca8a50d07a0acd82b3c57

[dvallet, 2017-01-30 04:59:55]

The CQ bit was checked by dvallet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 05:00:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dvallet, 2017-01-30 05:00:43]

Description was changed from

==========
Make headless_shell target compile for linux:
- Add necessary configs so exec file can be compiles
- Enable logging options (this is enforced in windows, otherwise logging path
will fail a DCHECK)
- Change screenshot file writting to use file_proxy, since file_stream does not
work properly in linux (it's harcoded
to use message_loop_io to do the write, which does not work in Windows since the
the FileThread is attached to the ui message loop
- Adds special rules in devtools code generation scripts to avoid collission
with windows specific macros (like ERR)
- Changes the way the command line is parsed so its compatible with Windows
- And some nits under #if defined(OS_WIN)


BUG=686608
==========

to

==========
Make headless_shell target compile for Windows:
- Add necessary configs so exec file can be compiles
- Enable logging options (this is enforced in windows, otherwise logging path
will fail a DCHECK)
- Change screenshot file writting to use file_proxy, since file_stream does not
work properly in linux (it's harcoded
to use message_loop_io to do the write, which does not work in Windows since the
the FileThread is attached to the ui message loop
- Adds special rules in devtools code generation scripts to avoid collission
with windows specific macros (like ERR)
- Changes the way the command line is parsed so its compatible with Windows
- And some nits under #if defined(OS_WIN)


BUG=686608
==========

[commit-bot: I haz the power, 2017-01-30 05:34:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 05:34:11]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dvallet, 2017-01-30 06:18:09]

dvallet@chromium.org changed reviewers:
+ samistil@chromium.org

[dvallet, 2017-01-30 06:18:09]

The CQ bit was checked by dvallet@chromium.org

[commit-bot: I haz the power, 2017-01-30 06:18:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 06:18:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 06:18:21]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[dvallet, 2017-01-30 06:19:43]

Description was changed from

==========
Make headless_shell target compile for Windows:
- Add necessary configs so exec file can be compiles
- Enable logging options (this is enforced in windows, otherwise logging path
will fail a DCHECK)
- Change screenshot file writting to use file_proxy, since file_stream does not
work properly in linux (it's harcoded
to use message_loop_io to do the write, which does not work in Windows since the
the FileThread is attached to the ui message loop
- Adds special rules in devtools code generation scripts to avoid collission
with windows specific macros (like ERR)
- Changes the way the command line is parsed so its compatible with Windows
- And some nits under #if defined(OS_WIN)


BUG=686608
==========

to

==========
Make headless_shell target compile for Windows:
- Add necessary configs so exec file can be compiled
- Enable logging options (this is enforced in windows, otherwise logging path
will fail with DCHECK)
- Change screenshot file writing to use file_proxy, since file_stream does not
work properly in linux: it's harcoded
to use message_loop_io to do the write, which does not work in Windows since the
the FileThread is attached to the ui message loop
- Adds special rules in devtools code generation scripts to avoid collision with
windows specific macros (like ERR)
- Changes the way the command line is parsed so its compatible with Windows
- And some nits under #if defined(OS_WIN)


BUG=686608
==========

[dvallet, 2017-01-30 06:20:28]

The CQ bit was checked by dvallet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 06:20:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dvallet, 2017-01-31 03:25:23]

The CQ bit was checked by dvallet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 03:25:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 04:09:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 04:09:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dvallet, 2017-01-31 06:26:08]

Description was changed from

==========
Make headless_shell target compile for Windows:
- Add necessary configs so exec file can be compiled
- Enable logging options (this is enforced in windows, otherwise logging path
will fail with DCHECK)
- Change screenshot file writing to use file_proxy, since file_stream does not
work properly in linux: it's harcoded
to use message_loop_io to do the write, which does not work in Windows since the
the FileThread is attached to the ui message loop
- Adds special rules in devtools code generation scripts to avoid collision with
windows specific macros (like ERR)
- Changes the way the command line is parsed so its compatible with Windows
- And some nits under #if defined(OS_WIN)


BUG=686608
==========

to

==========
Make headless_shell target compile for Windows:
- Add necessary configs so exec file can be compiled
- Enable logging options (this is enforced in windows, otherwise logging path
will fail with DCHECK)
- Change screenshot file writing to use file_proxy, since file_stream does not
work properly in linux: it's harcoded
to use message_loop_io to do the write, which does not work in Windows since the
the FileThread is attached to the ui message loop
- Adds special rules in devtools code generation scripts to avoid collision with
windows specific macros (like ERR)
- Changes the way the command line is parsed so its compatible with Windows
- Modify headless.gn args to be compatible with windows also.
- And some nits under #if defined(OS_WIN)


BUG=686608
==========

[dvallet, 2017-01-31 06:26:37]

The CQ bit was checked by dvallet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 06:26:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 07:39:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 07:39:40]

Dry run: This issue passed the CQ dry run.

[dvallet, 2017-02-07 03:25:11]

The CQ bit was checked by dvallet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 03:25:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 05:03:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 05:03:30]

Dry run: This issue passed the CQ dry run.

[dvallet, 2017-02-07 21:50:26]

dvallet@chromium.org changed reviewers:
+ skyostil@chromium.org
- samistil@chromium.org

[dvallet, 2017-02-08 22:38:46]

The CQ bit was checked by dvallet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 22:39:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 00:17:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 00:17:33]

Dry run: This issue passed the CQ dry run.

[dvallet, 2017-02-09 06:11:39]

PTAL, this is ready to review

[Sami, 2017-02-09 17:51:40]

Looks great! Just a couple of small comments.

https://codereview.chromium.org/2666503002/diff/200001/headless/BUILD.gn
File headless/BUILD.gn (right):

https://codereview.chromium.org/2666503002/diff/200001/headless/BUILD.gn#newc...
headless/BUILD.gn:386: if (is_win) {
Should these go into the headless_lib target since that's where the sandboxing
setup code lives too?

https://codereview.chromium.org/2666503002/diff/200001/headless/app/headless_...
File headless/app/headless_shell.cc (right):

https://codereview.chromium.org/2666503002/diff/200001/headless/app/headless_...
headless/app/headless_shell.cc:333: weak_factory_.GetWeakPtr(),
base::Passed(&result),
nit: Could you keep this base::Passed(std::move(result))? I find the shorter
form a bit misleading.

https://codereview.chromium.org/2666503002/diff/200001/headless/app/headless_...
File headless/app/headless_shell_main.cc (right):

https://codereview.chromium.org/2666503002/diff/200001/headless/app/headless_...
headless/app/headless_shell_main.cc:11: base::FilePath log_filename;
I've recently added support for logging
(https://codereview.chromium.org/2671713004/). Could you rebase and check
whether this part is still needed?

[dvallet, 2017-02-10 05:29:23]

The CQ bit was checked by dvallet@chromium.org to run a CQ dry run

[dvallet, 2017-02-10 05:29:49]

https://codereview.chromium.org/2666503002/diff/200001/headless/BUILD.gn
File headless/BUILD.gn (right):

https://codereview.chromium.org/2666503002/diff/200001/headless/BUILD.gn#newc...
headless/BUILD.gn:386: if (is_win) {
On 2017/02/09 at 17:51:40, Sami wrote:
> Should these go into the headless_lib target since that's where the sandboxing
setup code lives too?

Done

https://codereview.chromium.org/2666503002/diff/200001/headless/app/headless_...
File headless/app/headless_shell.cc (right):

https://codereview.chromium.org/2666503002/diff/200001/headless/app/headless_...
headless/app/headless_shell.cc:333: weak_factory_.GetWeakPtr(),
base::Passed(&result),
On 2017/02/09 at 17:51:40, Sami wrote:
> nit: Could you keep this base::Passed(std::move(result))? I find the shorter
form a bit misleading.

Done

https://codereview.chromium.org/2666503002/diff/200001/headless/app/headless_...
File headless/app/headless_shell_main.cc (right):

https://codereview.chromium.org/2666503002/diff/200001/headless/app/headless_...
headless/app/headless_shell_main.cc:11: base::FilePath log_filename;
On 2017/02/09 at 17:51:40, Sami wrote:
> I've recently added support for logging
(https://codereview.chromium.org/2671713004/). Could you rebase and check
whether this part is still needed?

Done. I think it should be working.

[commit-bot: I haz the power, 2017-02-10 05:30:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 07:00:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 07:00:45]

Dry run: This issue passed the CQ dry run.

[Sami, 2017-02-10 13:56:22]

Thanks, lgtm!

https://codereview.chromium.org/2666503002/diff/240001/headless/app/headless_...
File headless/app/headless_shell.cc (right):

https://codereview.chromium.org/2666503002/diff/240001/headless/app/headless_...
headless/app/headless_shell.cc:356: LOG(ERROR) << "About to call write: " <<
screenshot_file_proxy_->IsValid();
Probably don't want to land this :)

[dvallet, 2017-02-13 00:50:34]

https://codereview.chromium.org/2666503002/diff/200001/headless/app/headless_...
File headless/app/headless_shell_main.cc (right):

https://codereview.chromium.org/2666503002/diff/200001/headless/app/headless_...
headless/app/headless_shell_main.cc:11: base::FilePath log_filename;
On 2017/02/10 05:29:49, dvallet wrote:
> On 2017/02/09 at 17:51:40, Sami wrote:
> > I've recently added support for logging
> (https://codereview.chromium.org/2671713004/). Could you rebase and check
> whether this part is still needed?
> 
> Done. I think it should be working.

I've cheked is working in Windows. Though I had to enable logging always for
Windows by default

https://codereview.chromium.org/2666503002/diff/240001/headless/app/headless_...
File headless/app/headless_shell.cc (right):

https://codereview.chromium.org/2666503002/diff/240001/headless/app/headless_...
headless/app/headless_shell.cc:356: LOG(ERROR) << "About to call write: " <<
screenshot_file_proxy_->IsValid();
On 2017/02/10 at 13:56:22, Sami wrote:
> Probably don't want to land this :)
Good catch!
Probably not :)

[dvallet, 2017-02-13 00:51:46]

The CQ bit was checked by dvallet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 00:51:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 02:35:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 02:35:10]

Dry run: This issue passed the CQ dry run.

[dvallet, 2017-02-13 03:04:46]

The CQ bit was checked by dvallet@chromium.org

[dvallet, 2017-02-13 03:04:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2666503002/#ps260001
(title: "Fix initlogging placing, always enable logging in Windows")

[commit-bot: I haz the power, 2017-02-13 03:05:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 03:11:53]

CQ is committing da patch.

Bot data: {"patchset_id": 260001, "attempt_start_ts": 1486955086279870,
"parent_rev": "33f13724ed6d1a1a56b0f112767e62c36824e377", "commit_rev":
"79dd3437b6e5dddaafeca8a50d07a0acd82b3c57"}

[commit-bot: I haz the power, 2017-02-13 03:12:28]

Description was changed from

==========
Make headless_shell target compile for Windows:
- Add necessary configs so exec file can be compiled
- Enable logging options (this is enforced in windows, otherwise logging path
will fail with DCHECK)
- Change screenshot file writing to use file_proxy, since file_stream does not
work properly in linux: it's harcoded
to use message_loop_io to do the write, which does not work in Windows since the
the FileThread is attached to the ui message loop
- Adds special rules in devtools code generation scripts to avoid collision with
windows specific macros (like ERR)
- Changes the way the command line is parsed so its compatible with Windows
- Modify headless.gn args to be compatible with windows also.
- And some nits under #if defined(OS_WIN)


BUG=686608
==========

to

==========
Make headless_shell target compile for Windows:
- Add necessary configs so exec file can be compiled
- Enable logging options (this is enforced in windows, otherwise logging path
will fail with DCHECK)
- Change screenshot file writing to use file_proxy, since file_stream does not
work properly in linux: it's harcoded
to use message_loop_io to do the write, which does not work in Windows since the
the FileThread is attached to the ui message loop
- Adds special rules in devtools code generation scripts to avoid collision with
windows specific macros (like ERR)
- Changes the way the command line is parsed so its compatible with Windows
- Modify headless.gn args to be compatible with windows also.
- And some nits under #if defined(OS_WIN)


BUG=686608

Review-Url: https://codereview.chromium.org/2666503002
Cr-Commit-Position: refs/heads/master@{#449906}
Committed:
https://chromium.googlesource.com/chromium/src/+/79dd3437b6e5dddaafeca8a50d07...
==========

[commit-bot: I haz the power, 2017-02-13 03:12:29]

Committed patchset #14 (id:260001) as
https://chromium.googlesource.com/chromium/src/+/79dd3437b6e5dddaafeca8a50d07...