Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: headless/lib/browser/headless_browser_impl.cc

Issue 2666503002: Make headless_shell target compile for Windows (Closed)
Patch Set: Fix initlogging placing, always enable logging in Windows Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/lib/browser/devtools_api/domain_h.template ('k') | headless/lib/headless_browser_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/lib/browser/headless_browser_impl.cc
diff --git a/headless/lib/browser/headless_browser_impl.cc b/headless/lib/browser/headless_browser_impl.cc
index 93d6918a76c8d022a1f46f57296f2c8f5da45f1a..15a042ab3f4ff177331f431aca59f854bcdb2c37 100644
--- a/headless/lib/browser/headless_browser_impl.cc
+++ b/headless/lib/browser/headless_browser_impl.cc
@@ -203,8 +203,8 @@ HeadlessBrowserContext* HeadlessBrowserImpl::GetBrowserContextForId(
}
void RunChildProcessIfNeeded(int argc, const char** argv) {
- base::CommandLine command_line(argc, argv);
- if (!command_line.HasSwitch(switches::kProcessType))
+ if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kProcessType))
return;
HeadlessBrowser::Options::Builder builder(argc, argv);
@@ -223,8 +223,8 @@ int HeadlessBrowserMain(
browser_was_initialized = true;
// Child processes should not end up here.
- base::CommandLine command_line(options.argc, options.argv);
- DCHECK(!command_line.HasSwitch(switches::kProcessType));
+ DCHECK(!base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kProcessType));
#endif
return RunContentMain(std::move(options),
std::move(on_browser_start_callback));
« no previous file with comments | « headless/lib/browser/devtools_api/domain_h.template ('k') | headless/lib/headless_browser_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698