Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2666363002: Convert GuestViewBase to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert GuestViewBase to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2666363002 Cr-Commit-Position: refs/heads/master@{#447592} Committed: https://chromium.googlesource.com/chromium/src/+/03f7a2cb6811d08b7fc8dd2de21c1fefa34415b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M components/guest_view/browser/guest_view_base.h View 1 chunk +2 lines, -3 lines 0 comments Download
M components/guest_view/browser/guest_view_base.cc View 4 chunks +17 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jam
3 years, 10 months ago (2017-02-01 19:29:51 UTC) #7
Fady Samuel
lgtm
3 years, 10 months ago (2017-02-01 19:34:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666363002/1
3 years, 10 months ago (2017-02-01 20:10:04 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 20:17:04 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/03f7a2cb6811d08b7fc8dd2de21c...

Powered by Google App Engine
This is Rietveld 408576698