Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Side by Side Diff: components/guest_view/browser/guest_view_base.h

Issue 2666363002: Convert GuestViewBase to use the new navigation callbacks. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/guest_view/browser/guest_view_base.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_GUEST_VIEW_BROWSER_GUEST_VIEW_BASE_H_ 5 #ifndef COMPONENTS_GUEST_VIEW_BROWSER_GUEST_VIEW_BASE_H_
6 #define COMPONENTS_GUEST_VIEW_BROWSER_GUEST_VIEW_BASE_H_ 6 #define COMPONENTS_GUEST_VIEW_BROWSER_GUEST_VIEW_BASE_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <queue> 9 #include <queue>
10 10
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 bool PreHandleGestureEvent(content::WebContents* source, 223 bool PreHandleGestureEvent(content::WebContents* source,
224 const blink::WebGestureEvent& event) override; 224 const blink::WebGestureEvent& event) override;
225 void FindReply(content::WebContents* source, 225 void FindReply(content::WebContents* source,
226 int request_id, 226 int request_id,
227 int number_of_matches, 227 int number_of_matches,
228 const gfx::Rect& selection_rect, 228 const gfx::Rect& selection_rect,
229 int active_match_ordinal, 229 int active_match_ordinal,
230 bool final_update) override; 230 bool final_update) override;
231 231
232 // WebContentsObserver implementation. 232 // WebContentsObserver implementation.
233 void DidNavigateMainFrame( 233 void DidFinishNavigation(
234 const content::LoadCommittedDetails& details, 234 content::NavigationHandle* navigation_handle) override;
235 const content::FrameNavigateParams& params) override;
236 235
237 // Given a set of initialization parameters, a concrete subclass of 236 // Given a set of initialization parameters, a concrete subclass of
238 // GuestViewBase can create a specialized WebContents that it returns back to 237 // GuestViewBase can create a specialized WebContents that it returns back to
239 // GuestViewBase. 238 // GuestViewBase.
240 virtual void CreateWebContents( 239 virtual void CreateWebContents(
241 const base::DictionaryValue& create_params, 240 const base::DictionaryValue& create_params,
242 const WebContentsCreatedCallback& callback) = 0; 241 const WebContentsCreatedCallback& callback) = 0;
243 242
244 // This method is called after the guest has been attached to an embedder and 243 // This method is called after the guest has been attached to an embedder and
245 // suspended resource loads have been resumed. 244 // suspended resource loads have been resumed.
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
487 // This is used to ensure pending tasks will not fire after this object is 486 // This is used to ensure pending tasks will not fire after this object is
488 // destroyed. 487 // destroyed.
489 base::WeakPtrFactory<GuestViewBase> weak_ptr_factory_; 488 base::WeakPtrFactory<GuestViewBase> weak_ptr_factory_;
490 489
491 DISALLOW_COPY_AND_ASSIGN(GuestViewBase); 490 DISALLOW_COPY_AND_ASSIGN(GuestViewBase);
492 }; 491 };
493 492
494 } // namespace guest_view 493 } // namespace guest_view
495 494
496 #endif // COMPONENTS_GUEST_VIEW_BROWSER_GUEST_VIEW_BASE_H_ 495 #endif // COMPONENTS_GUEST_VIEW_BROWSER_GUEST_VIEW_BASE_H_
OLDNEW
« no previous file with comments | « no previous file | components/guest_view/browser/guest_view_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698