Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2666353002: Revert of Copy GPU workaround flags from browser to GPU process (Closed)

Created:
3 years, 10 months ago by Corentin Wallez
Modified:
3 years, 10 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, sunnyps
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Copy GPU workaround flags from browser to GPU process (patchset #4 id:20002 of https://codereview.chromium.org/2644733005/ ) Reason for revert: There is a gpu_unittests failure on OSX: AssertionError: Browser and GPU process list of driver bugworkarounds are not equal Starting from https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Retina%20Release/builds/10498 This CL seems like the culprit, reverting. Original issue's description: > Copy GPU workaround flags from browser to GPU process > > BUG=682912 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2644733005 > Cr-Commit-Position: refs/heads/master@{#447356} > Committed: https://chromium.googlesource.com/chromium/src/+/ded062d6c02a0cbfa89c90dae364c48f9118a328 TBR=kbr@chromium.org,zmo@chromium.org,kainino@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=682912 Review-Url: https://codereview.chromium.org/2666353002 Cr-Commit-Position: refs/heads/master@{#447523} Committed: https://chromium.googlesource.com/chromium/src/+/b684241f1f14948c108d715ebe7c5a9427a9fcd0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -50 lines) Patch
M content/browser/gpu/gpu_process_host.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M content/test/gpu/gpu_tests/gpu_process_integration_test.py View 2 chunks +1 line, -13 lines 0 comments Download
M gpu/config/gpu_driver_bug_list.h View 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/config/gpu_driver_bug_list.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 3 chunks +1 line, -14 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Corentin Wallez
Created Revert of Copy GPU workaround flags from browser to GPU process
3 years, 10 months ago (2017-02-01 16:00:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666353002/1
3 years, 10 months ago (2017-02-01 16:00:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b684241f1f14948c108d715ebe7c5a9427a9fcd0
3 years, 10 months ago (2017-02-01 16:03:30 UTC) #6
Kai Ninomiya
3 years, 10 months ago (2017-02-02 01:04:04 UTC) #7
Message was sent while issue was closed.
Oops, sorry. Definitely my patch. Thanks, I'll look into it.

Powered by Google App Engine
This is Rietveld 408576698