Copy GPU workaround flags from browser to GPU process

Copy GPU workaround flags from browser to GPU process

BUG=682912
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2644733005
Cr-Original-Commit-Position: refs/heads/master@{#447356}
Committed: https://chromium.googlesource.com/chromium/src/+/ded062d6c02a0cbfa89c90dae364c48f9118a328
Review-Url: https://codereview.chromium.org/2644733005
Cr-Commit-Position: refs/heads/master@{#453170}
Committed: https://chromium.googlesource.com/chromium/src/+/c48d029d278e71c7837e118a4d6f72951dd2dd05

[Kai Ninomiya, 2017-01-20 00:39:53]

Description was changed from

==========
Copy GPU workaround flags from browser to GPU process

BUG=682912
==========

to

==========
Copy GPU workaround flags from browser to GPU process

BUG=682912
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2017-01-20 00:42:04]

kainino@chromium.org changed reviewers:
+ kbr@chromium.org

[Kai Ninomiya, 2017-01-20 00:42:04]

PTAL

[Kai Ninomiya, 2017-01-20 01:03:20]

kainino@chromium.org changed reviewers:
+ zmo@chromium.org

[Kai Ninomiya, 2017-01-20 01:03:21]

zmo or kbr, PTAL

[Kai Ninomiya, 2017-01-20 01:04:23]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 01:05:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kai Ninomiya, 2017-01-20 01:07:01]

TODO to self: write test

[commit-bot: I haz the power, 2017-01-20 02:17:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 02:17:52]

Dry run: This issue passed the CQ dry run.

[Ken Russell (switch to Gerrit), 2017-01-20 03:10:01]

Thanks for putting this together Kai. It looks good in principle, but a test is
strongly needed.

The way to do this is to extend
src/content/test/gpu/gpu_tests/gpu_process_integration_test.py . I think a test
should look like this:

1) Define a new entry in src/gpu/config/gpu_driver_bug_list_json.cc with a fake
GPU vendor and device ID that activates the fake
use_gpu_driver_workaround_for_testing workaround.

2) Create a new test called something like
GpuProcess_disabling_workarounds_works. It should:

2a) use the --gpu-testing-vendor-id and --gpu-testing-device-id flags to
activate your new workaround
2b) Pass --use_gpu_driver_workaround_for_testing=0 on the browser's command line

3) Like _CompareAndCaptureDriverBugWorkarounds, the test should ensure that the
workarounds known by the browser and GPU processes are the same.

4) It should then assert that the fake workaround isn't present in either the
browser or GPU process.

It should be possible to write this test, comment out your fix, and watch it
fail; then put your fix in and watch it pass.

I'd like to hold back a thumbs-up on this CL until the test is written.

[Kai Ninomiya, 2017-01-31 01:59:12]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 01:59:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 02:02:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 02:02:41]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Kai Ninomiya, 2017-01-31 02:06:06]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 02:06:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kai Ninomiya, 2017-01-31 02:06:43]

kbr or zmo: PTAL at the test I added. I verified it failed before and passes
now.

[Ken Russell (switch to Gerrit), 2017-01-31 02:15:08]

Excellent work. LGTM

[commit-bot: I haz the power, 2017-01-31 02:48:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 02:48:38]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Kai Ninomiya, 2017-01-31 02:50:59]

oh no:

e:\b\c\b\win\src\gpu\config\gpu_driver_bug_list_json.cc(2352): error C2026:
string too big, trailing characters truncated

[Ken Russell (switch to Gerrit), 2017-01-31 17:00:30]

On 2017/01/31 02:50:59, Kai Ninomiya wrote:
> oh no:
> 
> e:\b\c\b\win\src\gpu\config\gpu_driver_bug_list_json.cc(2352): error C2026:
> string too big, trailing characters truncated

Maybe you can split it into two back-to-back LONG_STRING_CONST macro invocations
and the compiler will concatenate them?

[Kai Ninomiya, 2017-01-31 19:44:09]

The CQ bit was checked by kainino@chromium.org

[Kai Ninomiya, 2017-01-31 19:44:09]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2644733005/#ps20002
(title: "Fix C2026 (string too big) on Windows")

[commit-bot: I haz the power, 2017-01-31 19:44:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 23:15:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20002, "attempt_start_ts": 1485891849047350,
"parent_rev": "5f42ef10335277c152f30782723af6ee893d3f55", "commit_rev":
"ded062d6c02a0cbfa89c90dae364c48f9118a328"}

[commit-bot: I haz the power, 2017-01-31 23:16:26]

Description was changed from

==========
Copy GPU workaround flags from browser to GPU process

BUG=682912
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Copy GPU workaround flags from browser to GPU process

BUG=682912
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2644733005
Cr-Commit-Position: refs/heads/master@{#447356}
Committed:
https://chromium.googlesource.com/chromium/src/+/ded062d6c02a0cbfa89c90dae364...
==========

[commit-bot: I haz the power, 2017-01-31 23:16:27]

Committed patchset #4 (id:20002) as
https://chromium.googlesource.com/chromium/src/+/ded062d6c02a0cbfa89c90dae364...

[Corentin Wallez, 2017-02-01 16:00:31]

A revert of this CL (patchset #4 id:20002) has been created in
https://codereview.chromium.org/2666353002/ by cwallez@chromium.org.

The reason for reverting is: There is a gpu_unittests failure on OSX:
AssertionError: Browser and GPU process list of driver bugworkarounds are not
equal

Starting from
https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Retina%20Release...

This CL seems like the culprit, reverting..

[Kai Ninomiya, 2017-02-24 03:36:37]

Description was changed from

==========
Copy GPU workaround flags from browser to GPU process

BUG=682912
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2644733005
Cr-Commit-Position: refs/heads/master@{#447356}
Committed:
https://chromium.googlesource.com/chromium/src/+/ded062d6c02a0cbfa89c90dae364...
==========

to

==========
Copy GPU workaround flags from browser to GPU process

BUG=682912
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2644733005
Cr-Commit-Position: refs/heads/master@{#447356}
Committed:
https://chromium.googlesource.com/chromium/src/+/ded062d6c02a0cbfa89c90dae364...
==========

[Kai Ninomiya, 2017-02-24 03:38:01]

Description was changed from

==========
Copy GPU workaround flags from browser to GPU process

BUG=682912
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2644733005
Cr-Commit-Position: refs/heads/master@{#447356}
Committed:
https://chromium.googlesource.com/chromium/src/+/ded062d6c02a0cbfa89c90dae364...
==========

to

==========
Copy GPU workaround flags from browser to GPU process

BUG=682912
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2644733005
Cr-Commit-Position: refs/heads/master@{#447356}
Committed:
https://chromium.googlesource.com/chromium/src/+/ded062d6c02a0cbfa89c90dae364...
==========

[Kai Ninomiya, 2017-02-24 18:32:35]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 18:33:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 19:29:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 19:29:15]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Kai Ninomiya, 2017-02-24 19:39:15]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 19:39:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 21:13:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 21:13:28]

Dry run: This issue passed the CQ dry run.

[Ken Russell (switch to Gerrit), 2017-02-27 06:33:09]

Kai: your latest patch set passes all tests on my MBP Retina with dual Intel and
NVIDIA GPUs.

[Kai Ninomiya, 2017-02-27 07:01:33]

The CQ bit was checked by kainino@chromium.org

[Kai Ninomiya, 2017-02-27 07:01:33]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2644733005/#ps110001
(title: "fix merge error 2")

[commit-bot: I haz the power, 2017-02-27 07:01:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kai Ninomiya, 2017-02-27 07:03:35]

On 2017/02/27 06:33:09, Ken Russell wrote:
> Kai: your latest patch set passes all tests on my MBP Retina with dual Intel
and
> NVIDIA GPUs.

Thanks, submitting the patch.

[commit-bot: I haz the power, 2017-02-27 08:11:53]

CQ is committing da patch.

Bot data: {"patchset_id": 110001, "attempt_start_ts": 1488178893647510,
"parent_rev": "46b362641fc483d7d5fd0714d96db6dd39de39f6", "commit_rev":
"c48d029d278e71c7837e118a4d6f72951dd2dd05"}

[commit-bot: I haz the power, 2017-02-27 08:12:45]

Description was changed from

==========
Copy GPU workaround flags from browser to GPU process

BUG=682912
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2644733005
Cr-Commit-Position: refs/heads/master@{#447356}
Committed:
https://chromium.googlesource.com/chromium/src/+/ded062d6c02a0cbfa89c90dae364...
==========

to

==========
Copy GPU workaround flags from browser to GPU process

BUG=682912
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2644733005
Cr-Original-Commit-Position: refs/heads/master@{#447356}
Committed:
https://chromium.googlesource.com/chromium/src/+/ded062d6c02a0cbfa89c90dae364...
Review-Url: https://codereview.chromium.org/2644733005
Cr-Commit-Position: refs/heads/master@{#453170}
Committed:
https://chromium.googlesource.com/chromium/src/+/c48d029d278e71c7837e118a4d6f...
==========

[commit-bot: I haz the power, 2017-02-27 08:12:47]

Committed patchset #7 (id:110001) as
https://chromium.googlesource.com/chromium/src/+/c48d029d278e71c7837e118a4d6f...