Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 266633003: Fix findbugs warning - narrow synchronization scope in NmDumper. (Closed)

Created:
6 years, 7 months ago by tommycli
Modified:
6 years, 7 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix findbugs warning - narrow synchronization scope in NmDumper. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267601

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 chunk +0 lines, -1 line 0 comments Download
M tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java View 2 chunks +9 lines, -7 lines 2 comments Download

Messages

Total messages: 11 (0 generated)
tommycli
https://codereview.chromium.org/266633003/diff/1/tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java File tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java (right): https://codereview.chromium.org/266633003/diff/1/tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java#newcode125 tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java:125: synchronized (writer) { This fixes a FindBugs warning. It ...
6 years, 7 months ago (2014-04-30 22:15:30 UTC) #1
Andrew Hayden (chromium.org)
lgtm thanks! https://codereview.chromium.org/266633003/diff/1/tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java File tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java (right): https://codereview.chromium.org/266633003/diff/1/tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java#newcode125 tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java:125: synchronized (writer) { On 2014/04/30 22:15:30, tommycli ...
6 years, 7 months ago (2014-05-01 12:56:25 UTC) #2
tommycli
The CQ bit was checked by tommycli@chromium.org
6 years, 7 months ago (2014-05-01 15:44:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/266633003/1
6 years, 7 months ago (2014-05-01 15:45:21 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 15:45:22 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-01 15:45:22 UTC) #6
tommycli
thestig: do you want to stamp this? It was approved by the maintainer.
6 years, 7 months ago (2014-05-01 16:07:46 UTC) #7
Lei Zhang
lgtm
6 years, 7 months ago (2014-05-01 18:05:26 UTC) #8
tommycli
The CQ bit was checked by tommycli@chromium.org
6 years, 7 months ago (2014-05-01 18:37:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/266633003/1
6 years, 7 months ago (2014-05-01 18:37:54 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-01 19:00:52 UTC) #11
Message was sent while issue was closed. 
Change committed as 267601

Powered by Google App Engine
This is Rietveld 408576698