build/android/findbugs_filter/findbugs_known_bugs.txt - Issue 266633003: Fix findbugs warning - narrow synchronization scope in NmDumper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/findbugs_filter/findbugs_known_bugs.txt

Issue 266633003: Fix findbugs warning - narrow synchronization scope in NmDumper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java » ('j') | tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/findbugs_filter/findbugs_known_bugs.txt

diff --git a/build/android/findbugs_filter/findbugs_known_bugs.txt b/build/android/findbugs_filter/findbugs_known_bugs.txt

index 082a9e98b43484bfcd700b68dfa3ab7855fc52cb..571b120549498813cd92b69587e7115dde55319e 100644

--- a/build/android/findbugs_filter/findbugs_known_bugs.txt

+++ b/build/android/findbugs_filter/findbugs_known_bugs.txt

@@ -34,5 +34,4 @@ M V MS: org.chromium.content.browser.LoadUrlParams.UA_OVERRIDE_TRUE isn't final

M M LI: Incorrect lazy initialization of static field org.chromium.chrome.browser.sync.ProfileSyncService.sSyncSetupManager in org.chromium.chrome.browser.sync.ProfileSyncService.get(Context) At ProfileSyncService.java

M B OS: org.chromium.tools.binary_size.Addr2LineWorkerPool$Addr2LineWorker$Addr2LineTask.run() may fail to close stream At Addr2LineWorkerPool.java

M B RV: Exceptional return value of java.io.File.mkdirs() ignored in new org.chromium.tools.binary_size.NmDumper$Output(NmDumper) At NmDumper.java

-M C CSM: Shouldn't use synchronized method, please narrow down the synchronization scope. At NmDumper.java

M D REC: Exception is caught when Exception is not thrown in org.chromium.tools.binary_size.Addr2LineWorkerPool$Addr2LineWorker$Addr2LineTask.run() At Addr2LineWorkerPool.java