Fix findbugs warning - narrow synchronization scope in NmDumper.

tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java

Index: tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java
diff --git a/tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java b/tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java
index 0d77e37f63d397e543d163da9cb3c1edfd5b6b17..286fd61bb9fd50838dffde6271806e1442a3270f 100644
--- a/tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java
+++ b/tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java
@@ -120,23 +120,25 @@ class NmDumper {
             }
         }
 
-        private synchronized void println(PrintWriter writer, String string) {
+        private void println(PrintWriter writer, String string) {
             if (writer != null) {
-                writer.println(string);
-                writer.flush();
+                synchronized (writer) {

[tommycli, 2014/04/30 22:15:30]

This fixes a FindBugs warning. It does slightly change the behavior though.

Previously, the logs of skipped, failed, and succeeded would show all the
entries in the same order.

Now the order may differ between them. I'm not sure if you care though.

[Andrew Hayden (chromium.org), 2014/05/01 12:56:26]

That should be fine. Order isn't critical, only avoiding corruption.

+                    writer.println(string);
+                    writer.flush();
+                }
             }
         }
 
-        synchronized void print(String string) {
+        void print(String string) {
             println(outWriter, string);
         }
 
-        synchronized void printSkip(String string) {
+        void printSkip(String string) {
             println(skipWriter, string);
             println(outWriter, string);
         }
 
-        synchronized void printFail(String string) {
+        void printFail(String string) {
             println(failWriter, string);
             println(outWriter, string);
         }
@@ -158,4 +160,4 @@ class NmDumper {
             }
         }
     }
-}
+}