[Cronet] Fix CronetHttpURLConnection#getResponse() hang

[Cronet] Fix CronetHttpURLConnection#getResponse() hang

This CL fixes a hang case where both request body and response body are
zero-length. |mHasResponseHeadersOrCompleted| was only properly set if
client always reads response body. This is a false assumption. This CL
moves setting of |mHasResponseHeadersOrCompleted| to
onResponseStarted() callback.

BUG=687600
NOTRY=true
NOPRESUBMIT=true


Review-Url: https://codereview.chromium.org/2663063009
Cr-Commit-Position: refs/heads/master@{#447554}
(cherry picked from commit 5e61cddf30c3bd3490b86f87ff6ea71bf05f0368)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2666323003
Cr-Commit-Position: refs/branch-heads/2987@{#251}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/4a744fb52679ebf065e6d910a26d58396b715dc1

[xunjieli, 2017-02-01 18:22:36]

Description was changed from

==========
[Cronet] Fix CronetHttpURLConnection#getResponse() hang

This CL fixes a hang case where both request body and response body are
zero-length. |mHasResponseHeadersOrCompleted| was only properly set if
client always reads response body. This is a false assumption. This CL
moves setting of |mHasResponseHeadersOrCompleted| to
onResponseStarted() callback.

BUG=687600

Review-Url: https://codereview.chromium.org/2663063009
Cr-Commit-Position: refs/heads/master@{#447554}
(cherry picked from commit 5e61cddf30c3bd3490b86f87ff6ea71bf05f0368)
==========

to

==========
[Cronet] Fix CronetHttpURLConnection#getResponse() hang

This CL fixes a hang case where both request body and response body are
zero-length. |mHasResponseHeadersOrCompleted| was only properly set if
client always reads response body. This is a false assumption. This CL
moves setting of |mHasResponseHeadersOrCompleted| to
onResponseStarted() callback.

BUG=687600

Review-Url: https://codereview.chromium.org/2663063009
Cr-Commit-Position: refs/heads/master@{#447554}
(cherry picked from commit 5e61cddf30c3bd3490b86f87ff6ea71bf05f0368)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[xunjieli, 2017-02-01 18:24:22]

xunjieli@chromium.org changed reviewers:
+ kapishnikov@chromium.org, mef@chromium.org

[xunjieli, 2017-02-01 18:24:23]

+mef@. Misha: can I merge this CL into M57?

[mef, 2017-02-01 18:41:39]

On 2017/02/01 18:24:23, xunjieli wrote:
> +mef@. Misha: can I merge this CL into M57?

I think so, this is legitimate bug fix, so I think that should meet merge
criteria.
Having that said I think we should still request the merge by setting label on
the bug.

[xunjieli, 2017-02-01 18:52:04]

On 2017/02/01 18:41:39, mef wrote:
> On 2017/02/01 18:24:23, xunjieli wrote:
> > +mef@. Misha: can I merge this CL into M57?
> 
> I think so, this is legitimate bug fix, so I think that should meet merge
> criteria.
> Having that said I think we should still request the merge by setting label on
> the bug.

SGTM! I have requested a merge. Thank you.

[mef, 2017-02-01 19:14:16]

On 2017/02/01 18:52:04, xunjieli wrote:
> On 2017/02/01 18:41:39, mef wrote:
> > On 2017/02/01 18:24:23, xunjieli wrote:
> > > +mef@. Misha: can I merge this CL into M57?
> > 
> > I think so, this is legitimate bug fix, so I think that should meet merge
> > criteria.
> > Having that said I think we should still request the merge by setting label
on
> > the bug.
> 
> SGTM! I have requested a merge. Thank you.

The merge got auto-approved, so lgtm.

[xunjieli, 2017-02-01 19:16:17]

On 2017/02/01 19:14:16, mef wrote:
> On 2017/02/01 18:52:04, xunjieli wrote:
> > On 2017/02/01 18:41:39, mef wrote:
> > > On 2017/02/01 18:24:23, xunjieli wrote:
> > > > +mef@. Misha: can I merge this CL into M57?
> > > 
> > > I think so, this is legitimate bug fix, so I think that should meet merge
> > > criteria.
> > > Having that said I think we should still request the merge by setting
label
> on
> > > the bug.
> > 
> > SGTM! I have requested a merge. Thank you.
> 
> The merge got auto-approved, so lgtm.

Thanks. I just finished running tests locally as well.

[xunjieli, 2017-02-01 19:16:20]

The CQ bit was checked by xunjieli@chromium.org

[xunjieli, 2017-02-01 19:16:26]

The CQ bit was unchecked by xunjieli@chromium.org

[xunjieli, 2017-02-01 19:16:46]

Description was changed from

==========
[Cronet] Fix CronetHttpURLConnection#getResponse() hang

This CL fixes a hang case where both request body and response body are
zero-length. |mHasResponseHeadersOrCompleted| was only properly set if
client always reads response body. This is a false assumption. This CL
moves setting of |mHasResponseHeadersOrCompleted| to
onResponseStarted() callback.

BUG=687600

Review-Url: https://codereview.chromium.org/2663063009
Cr-Commit-Position: refs/heads/master@{#447554}
(cherry picked from commit 5e61cddf30c3bd3490b86f87ff6ea71bf05f0368)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] Fix CronetHttpURLConnection#getResponse() hang

This CL fixes a hang case where both request body and response body are
zero-length. |mHasResponseHeadersOrCompleted| was only properly set if
client always reads response body. This is a false assumption. This CL
moves setting of |mHasResponseHeadersOrCompleted| to
onResponseStarted() callback.

BUG=687600
NOTRY=true
NOPRESUBMIT=true


Review-Url: https://codereview.chromium.org/2663063009
Cr-Commit-Position: refs/heads/master@{#447554}
(cherry picked from commit 5e61cddf30c3bd3490b86f87ff6ea71bf05f0368)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[xunjieli, 2017-02-01 19:16:55]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2017-02-01 19:17:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 19:25:38]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485976615958160, "parent_rev":
"3aa2f5150aa815142dc94c8a3e8ab52f1ec23573", "commit_rev":
"4a744fb52679ebf065e6d910a26d58396b715dc1"}

[commit-bot: I haz the power, 2017-02-01 19:26:12]

Description was changed from

==========
[Cronet] Fix CronetHttpURLConnection#getResponse() hang

This CL fixes a hang case where both request body and response body are
zero-length. |mHasResponseHeadersOrCompleted| was only properly set if
client always reads response body. This is a false assumption. This CL
moves setting of |mHasResponseHeadersOrCompleted| to
onResponseStarted() callback.

BUG=687600
NOTRY=true
NOPRESUBMIT=true


Review-Url: https://codereview.chromium.org/2663063009
Cr-Commit-Position: refs/heads/master@{#447554}
(cherry picked from commit 5e61cddf30c3bd3490b86f87ff6ea71bf05f0368)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] Fix CronetHttpURLConnection#getResponse() hang

This CL fixes a hang case where both request body and response body are
zero-length. |mHasResponseHeadersOrCompleted| was only properly set if
client always reads response body. This is a false assumption. This CL
moves setting of |mHasResponseHeadersOrCompleted| to
onResponseStarted() callback.

BUG=687600
NOTRY=true
NOPRESUBMIT=true


Review-Url: https://codereview.chromium.org/2663063009
Cr-Commit-Position: refs/heads/master@{#447554}
(cherry picked from commit 5e61cddf30c3bd3490b86f87ff6ea71bf05f0368)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2666323003
Cr-Commit-Position: refs/branch-heads/2987@{#251}
Cr-Branched-From:
ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed:
https://chromium.googlesource.com/chromium/src/+/4a744fb52679ebf065e6d910a26d...
==========

[commit-bot: I haz the power, 2017-02-01 19:26:13]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4a744fb52679ebf065e6d910a26d...