[Cronet] Fix CronetHttpURLConnection#getResponse() hang

[Cronet] Fix CronetHttpURLConnection#getResponse() hang

This CL fixes a hang case where both request body and response body are
zero-length. |mHasResponseHeadersOrCompleted| was only properly set if 
client always reads response body. This is a false assumption. This CL 
moves setting of |mHasResponseHeadersOrCompleted| to 
onResponseStarted() callback.

R=kapishnikov@chromium.org

BUG=687600
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2663063009
Cr-Commit-Position: refs/heads/master@{#447554}
Committed: https://chromium.googlesource.com/chromium/src/+/5e61cddf30c3bd3490b86f87ff6ea71bf05f0368

[xunjieli, 2017-02-01 16:16:58]

Description was changed from

==========
[Cronet] Fix CronetHttpURLConnection#getResponse() hang

This CL fixes a hang case where both request body and response body is
zero-length. |mHasResponseHeaders| was only properly set if client always
read response body. This is a false assumption. This CL moves
setting |mHasResponseHeaders| to onResponseStarted() callback.

R=pauljensen@chromium.org

BUG=687600
==========

to

==========
[Cronet] Fix CronetHttpURLConnection#getResponse() hang

This CL fixes a hang case where both request body and response body is
zero-length. |mHasResponseHeaders| was only properly set if client always
read response body. This is a false assumption. This CL moves
setting |mHasResponseHeaders| to onResponseStarted() callback.

R=pauljensen@chromium.org

BUG=687600
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[xunjieli, 2017-02-01 16:17:47]

Paul, do you have cycle to review this?
Thanks!

[xunjieli, 2017-02-01 16:18:51]

Description was changed from

==========
[Cronet] Fix CronetHttpURLConnection#getResponse() hang

This CL fixes a hang case where both request body and response body is
zero-length. |mHasResponseHeaders| was only properly set if client always
read response body. This is a false assumption. This CL moves
setting |mHasResponseHeaders| to onResponseStarted() callback.

R=pauljensen@chromium.org

BUG=687600
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] Fix CronetHttpURLConnection#getResponse() hang

This CL fixes a hang case where both request body and response body are
zero-length. |mHasResponseHeaders| was only properly set if client always
read response body. This is a false assumption. This CL moves
setting |mHasResponseHeaders| to onResponseStarted() callback.

R=pauljensen@chromium.org

BUG=687600
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[xunjieli, 2017-02-01 16:18:59]

Description was changed from

==========
[Cronet] Fix CronetHttpURLConnection#getResponse() hang

This CL fixes a hang case where both request body and response body are
zero-length. |mHasResponseHeaders| was only properly set if client always
read response body. This is a false assumption. This CL moves
setting |mHasResponseHeaders| to onResponseStarted() callback.

R=pauljensen@chromium.org

BUG=687600
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] Fix CronetHttpURLConnection#getResponse() hang

This CL fixes a hang case where both request body and response body are
zero-length. |mHasResponseHeaders| was only properly set if client always
reads response body. This is a false assumption. This CL moves
setting |mHasResponseHeaders| to onResponseStarted() callback.

R=pauljensen@chromium.org

BUG=687600
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[pauljensen, 2017-02-01 16:20:07]

On 2017/02/01 16:17:47, xunjieli wrote:
> Paul, do you have cycle to review this?
> Thanks!

Not sure if I'll have a chance in the next week :(  Maybe, maybe not.

[xunjieli, 2017-02-01 16:27:05]

xunjieli@chromium.org changed reviewers:
+ kapishnikov@chromium.org

[xunjieli, 2017-02-01 16:27:05]

> Not sure if I'll have a chance in the next week :(  Maybe, maybe not.

np, I totally understand.
Andrei, could you take this?

[xunjieli, 2017-02-01 17:01:43]

Description was changed from

==========
[Cronet] Fix CronetHttpURLConnection#getResponse() hang

This CL fixes a hang case where both request body and response body are
zero-length. |mHasResponseHeaders| was only properly set if client always
reads response body. This is a false assumption. This CL moves
setting |mHasResponseHeaders| to onResponseStarted() callback.

R=pauljensen@chromium.org

BUG=687600
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] Fix CronetHttpURLConnection#getResponse() hang

This CL fixes a hang case where both request body and response body are
zero-length. |mHasResponseHeadersOrCompleted| was only properly set if 
client always reads response body. This is a false assumption. This CL 
moves setting |mHasResponseHeadersOrCompleted| to onResponseStarted() 
callback.

R=kapishnikov@chromium.org

BUG=687600
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[kapishnikov, 2017-02-01 17:51:45]

lgtm

[xunjieli, 2017-02-01 17:52:10]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2017-02-01 17:52:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2017-02-01 17:52:31]

Description was changed from

==========
[Cronet] Fix CronetHttpURLConnection#getResponse() hang

This CL fixes a hang case where both request body and response body are
zero-length. |mHasResponseHeadersOrCompleted| was only properly set if 
client always reads response body. This is a false assumption. This CL 
moves setting |mHasResponseHeadersOrCompleted| to onResponseStarted() 
callback.

R=kapishnikov@chromium.org

BUG=687600
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] Fix CronetHttpURLConnection#getResponse() hang

This CL fixes a hang case where both request body and response body are
zero-length. |mHasResponseHeadersOrCompleted| was only properly set if 
client always reads response body. This is a false assumption. This CL 
moves setting of |mHasResponseHeadersOrCompleted| to 
onResponseStarted() callback.

R=kapishnikov@chromium.org

BUG=687600
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[commit-bot: I haz the power, 2017-02-01 18:08:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485971530834600,
"parent_rev": "a3d219a96ce9200ce17be29b4debe00b08159f15", "commit_rev":
"5e61cddf30c3bd3490b86f87ff6ea71bf05f0368"}

[commit-bot: I haz the power, 2017-02-01 18:09:50]

Description was changed from

==========
[Cronet] Fix CronetHttpURLConnection#getResponse() hang

This CL fixes a hang case where both request body and response body are
zero-length. |mHasResponseHeadersOrCompleted| was only properly set if 
client always reads response body. This is a false assumption. This CL 
moves setting of |mHasResponseHeadersOrCompleted| to 
onResponseStarted() callback.

R=kapishnikov@chromium.org

BUG=687600
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] Fix CronetHttpURLConnection#getResponse() hang

This CL fixes a hang case where both request body and response body are
zero-length. |mHasResponseHeadersOrCompleted| was only properly set if 
client always reads response body. This is a false assumption. This CL 
moves setting of |mHasResponseHeadersOrCompleted| to 
onResponseStarted() callback.

R=kapishnikov@chromium.org

BUG=687600
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2663063009
Cr-Commit-Position: refs/heads/master@{#447554}
Committed:
https://chromium.googlesource.com/chromium/src/+/5e61cddf30c3bd3490b86f87ff6e...
==========

[commit-bot: I haz the power, 2017-02-01 18:09:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5e61cddf30c3bd3490b86f87ff6e...