Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu.cc

Issue 2666193002: Switch RenderViewContextMenu to use RequestOpenURL (Closed)
Patch Set: Address Charlie's comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_context_menu/render_view_context_menu.cc
diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
index c2f9143c2ffbb612dd88bc9437771c82b99deb77..f86db71d8c2bd0bb784b87ddb39ee6aa4ccf0db2 100644
--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc
+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
@@ -49,7 +49,6 @@
#include "chrome/browser/search/search.h"
#include "chrome/browser/search_engines/template_url_service_factory.h"
#include "chrome/browser/spellchecker/spellcheck_service.h"
-#include "chrome/browser/tab_contents/retargeting_details.h"
#include "chrome/browser/translate/chrome_translate_client.h"
#include "chrome/browser/translate/translate_service.h"
#include "chrome/browser/ui/browser_commands.h"
@@ -1966,24 +1965,6 @@ void RenderViewContextMenu::NotifyMenuShown() {
content::NotificationService::NoDetails());
}
-void RenderViewContextMenu::NotifyURLOpened(
- const GURL& url,
- content::WebContents* new_contents) {
- RetargetingDetails details;
- details.source_web_contents = source_web_contents_;
- // Don't use GetRenderFrameHost() as it may be NULL. crbug.com/399789
- details.source_render_process_id = render_process_id_;
- details.source_render_frame_id = render_frame_id_;
- details.target_url = url;
- details.target_web_contents = new_contents;
- details.not_yet_in_tabstrip = false;
-
- content::NotificationService::current()->Notify(
- chrome::NOTIFICATION_RETARGETING,
Avi (use Gerrit) 2017/02/17 22:52:07 Whoo!
- content::Source<Profile>(GetProfile()),
- content::Details<RetargetingDetails>(&details));
-}
-
base::string16 RenderViewContextMenu::PrintableSelectionText() {
return gfx::TruncateString(params_.selection_text,
kMaxSelectionTextLength,

Powered by Google App Engine
This is Rietveld 408576698