chrome/browser/renderer_context_menu/render_view_context_menu.h - Issue 2666193002: Switch RenderViewContextMenu to use RequestOpenURL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu.h

Issue 2666193002: Switch RenderViewContextMenu to use RequestOpenURL (Closed)

Patch Set: Address Charlie's comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/renderer_context_menu/render_view_context_menu.h

diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.h b/chrome/browser/renderer_context_menu/render_view_context_menu.h

index ef8b1a8133cd90a00c62d56d10d547b7171fe91e..0239d2c0e5caf6f64d8df44104567956f40c5c12 100644

--- a/chrome/browser/renderer_context_menu/render_view_context_menu.h

+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.h

@@ -121,8 +121,6 @@ class RenderViewContextMenu : public RenderViewContextMenuBase {

void HandleAuthorizeAllPlugins() override;

#endif

void NotifyMenuShown() override;

- void NotifyURLOpened(const GURL& url,

- content::WebContents* new_contents) override;

// Gets the extension (if any) associated with the WebContents that we're in.

const extensions::Extension* GetExtension() const;