components/renderer_context_menu/render_view_context_menu_base.h - Issue 2666193002: Switch RenderViewContextMenu to use RequestOpenURL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/renderer_context_menu/render_view_context_menu_base.h

Issue 2666193002: Switch RenderViewContextMenu to use RequestOpenURL (Closed)

Patch Set: Address Charlie's comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/renderer_context_menu/render_view_context_menu_base.h

diff --git a/components/renderer_context_menu/render_view_context_menu_base.h b/components/renderer_context_menu/render_view_context_menu_base.h

index 84fcfe5af353ccdd52255e35b9c7166c89bca640..849b29c3a056211c3b6f618bded1800f4429ef78 100644

--- a/components/renderer_context_menu/render_view_context_menu_base.h

+++ b/components/renderer_context_menu/render_view_context_menu_base.h

@@ -142,8 +142,6 @@ class RenderViewContextMenuBase : public ui::SimpleMenuModel::Delegate,

// Subclasses should send notification.

virtual void NotifyMenuShown() = 0;

- virtual void NotifyURLOpened(const GURL& url,

- content::WebContents* new_contents) = 0;

// TODO(oshima): Remove this.

virtual void AppendPlatformEditableItems() {}