chrome/browser/extensions/api/web_navigation/web_navigation_api.cc - Issue 2666193002: Switch RenderViewContextMenu to use RequestOpenURL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

Issue 2666193002: Switch RenderViewContextMenu to use RequestOpenURL (Closed)

Patch Set: Address Charlie's comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

index 3feaa460c847383ceefedd8b3076d46f89b0d485..2616a7568fdc8c527ef4d9ac2a9c7525f9942436 100644

--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

@@ -383,7 +383,8 @@ void WebNavigationTabObserver::DidOpenRequestedURL(

const GURL& url,

const content::Referrer& referrer,

WindowOpenDisposition disposition,

- ui::PageTransition transition) {

+ ui::PageTransition transition,

+ bool started_from_context_menu) {

if (!navigation_state_.CanSendEvents(source_render_frame_host))

return;