chrome/browser/extensions/api/web_navigation/web_navigation_api.h - Issue 2666193002: Switch RenderViewContextMenu to use RequestOpenURL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.h

Issue 2666193002: Switch RenderViewContextMenu to use RequestOpenURL (Closed)

Patch Set: Address Charlie's comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.h

diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.h b/chrome/browser/extensions/api/web_navigation/web_navigation_api.h

index c663e68fb58ebd86a4e56a06cd6ff47510787e3e..e467d996d21ca4075fa414320189d7c785a18afb 100644

--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.h

+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.h

@@ -68,7 +68,8 @@ class WebNavigationTabObserver

const GURL& url,

const content::Referrer& referrer,

WindowOpenDisposition disposition,

- ui::PageTransition transition) override;

+ ui::PageTransition transition,

+ bool started_from_context_menu) override;

void WebContentsDestroyed() override;

// This method dispatches the already created onBeforeNavigate event.