Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5258)

Unified Diff: chrome/browser/ui/webui/settings/site_settings_handler.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/site_settings_handler.cc
diff --git a/chrome/browser/ui/webui/settings/site_settings_handler.cc b/chrome/browser/ui/webui/settings/site_settings_handler.cc
index 9c17f2e19ba33fdf14ef09a3a2c1e1b1592c686f..08b1e24eb217e261845df9aedcb1d4904cf4376d 100644
--- a/chrome/browser/ui/webui/settings/site_settings_handler.cc
+++ b/chrome/browser/ui/webui/settings/site_settings_handler.cc
@@ -208,7 +208,7 @@ void SiteSettingsHandler::OnGetUsageInfo(
CallJavascriptFunction("settings.WebsiteUsagePrivateApi.returnUsageTotal",
base::StringValue(entry.host),
base::StringValue(ui::FormatBytes(entry.usage)),
- base::FundamentalValue(entry.type));
+ base::Value(entry.type));
return;
}
}
@@ -596,8 +596,7 @@ void SiteSettingsHandler::HandleIsPatternValid(
ContentSettingsPattern pattern =
ContentSettingsPattern::FromString(pattern_string);
- ResolveJavascriptCallback(
- *callback_id, base::FundamentalValue(pattern.IsValid()));
+ ResolveJavascriptCallback(*callback_id, base::Value(pattern.IsValid()));
}
void SiteSettingsHandler::HandleUpdateIncognitoStatus(
@@ -619,7 +618,7 @@ void SiteSettingsHandler::SendIncognitoStatus(
CallJavascriptFunction("cr.webUIListenerCallback",
base::StringValue("onIncognitoStatusChanged"),
- base::FundamentalValue(incognito_enabled));
+ base::Value(incognito_enabled));
}
void SiteSettingsHandler::HandleFetchZoomLevels(const base::ListValue* args) {

Powered by Google App Engine
This is Rietveld 408576698