chrome/browser/ui/webui/signin/sync_confirmation_handler_unittest.cc - Issue 2666093002: Remove base::FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/sync_confirmation_handler_unittest.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/settings/site_settings_handler.cc ('k') | chrome/browser/ui/webui/signin/user_manager_screen_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/signin/sync_confirmation_handler_unittest.cc

diff --git a/chrome/browser/ui/webui/signin/sync_confirmation_handler_unittest.cc b/chrome/browser/ui/webui/signin/sync_confirmation_handler_unittest.cc

index 3ecf60e6c792130bb43f869515a5833c445d59ed..3dd0f4fccc97c53b9e9b39f18a70958d88c6d925 100644

--- a/chrome/browser/ui/webui/signin/sync_confirmation_handler_unittest.cc

+++ b/chrome/browser/ui/webui/signin/sync_confirmation_handler_unittest.cc

@@ -144,7 +144,7 @@ TEST_F(SyncConfirmationHandlerTest, TestSetImageIfPrimaryAccountReady) {

"http://picture.example.com/picture.jpg");

base::ListValue args;

- args.Set(0, new base::FundamentalValue(kDefaultDialogHeight));

+ args.Set(0, new base::Value(kDefaultDialogHeight));

handler()->HandleInitializedWithSize(&args);

EXPECT_EQ(2U, web_ui()->call_data().size());

@@ -173,7 +173,7 @@ TEST_F(SyncConfirmationHandlerTest, TestSetImageIfPrimaryAccountReady) {

TEST_F(SyncConfirmationHandlerTest, TestSetImageIfPrimaryAccountReadyLater) {

base::ListValue args;

- args.Set(0, new base::FundamentalValue(kDefaultDialogHeight));

+ args.Set(0, new base::Value(kDefaultDialogHeight));

handler()->HandleInitializedWithSize(&args);

EXPECT_EQ(2U, web_ui()->call_data().size());

@@ -225,7 +225,7 @@ TEST_F(SyncConfirmationHandlerTest, TestSetImageIfPrimaryAccountReadyLater) {

TEST_F(SyncConfirmationHandlerTest,

TestSetImageIgnoredIfSecondaryAccountUpdated) {

base::ListValue args;

- args.Set(0, new base::FundamentalValue(kDefaultDialogHeight));

+ args.Set(0, new base::Value(kDefaultDialogHeight));

handler()->HandleInitializedWithSize(&args);

EXPECT_EQ(2U, web_ui()->call_data().size());