Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2026)

Unified Diff: chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc
diff --git a/chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc b/chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc
index 78696a640e46c937f447dd242f8b11801eb8f4fa..2acbea12b4b81ac6def1237c9125151e515e2df8 100644
--- a/chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc
+++ b/chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc
@@ -113,7 +113,7 @@ void StartupPagesHandler::HandleAddStartupPage(const base::ListValue* args) {
GURL url;
if (!settings_utils::FixupAndValidateStartupPage(url_string, &url)) {
- ResolveJavascriptCallback(*callback_id, base::FundamentalValue(false));
+ ResolveJavascriptCallback(*callback_id, base::Value(false));
return;
}
@@ -124,7 +124,7 @@ void StartupPagesHandler::HandleAddStartupPage(const base::ListValue* args) {
startup_custom_pages_table_model_.Add(index, url);
SaveStartupPagesPref();
- ResolveJavascriptCallback(*callback_id, base::FundamentalValue(true));
+ ResolveJavascriptCallback(*callback_id, base::Value(true));
}
void StartupPagesHandler::HandleEditStartupPage(const base::ListValue* args) {
@@ -149,9 +149,9 @@ void StartupPagesHandler::HandleEditStartupPage(const base::ListValue* args) {
urls[index] = fixed_url;
startup_custom_pages_table_model_.SetURLs(urls);
SaveStartupPagesPref();
- ResolveJavascriptCallback(*callback_id, base::FundamentalValue(true));
+ ResolveJavascriptCallback(*callback_id, base::Value(true));
} else {
- ResolveJavascriptCallback(*callback_id, base::FundamentalValue(false));
+ ResolveJavascriptCallback(*callback_id, base::Value(false));
}
}
@@ -194,7 +194,7 @@ void StartupPagesHandler::HandleValidateStartupPage(
CHECK(args->GetString(1, &url_string));
bool valid = settings_utils::FixupAndValidateStartupPage(url_string, nullptr);
- ResolveJavascriptCallback(*callback_id, base::FundamentalValue(valid));
+ ResolveJavascriptCallback(*callback_id, base::Value(valid));
}
void StartupPagesHandler::SaveStartupPagesPref() {

Powered by Google App Engine
This is Rietveld 408576698