Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3749)

Unified Diff: chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
diff --git a/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc b/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
index 6d263d8ca56762c400a4828244b9a1e76c2a838c..ea54ef47a0d0c70bac6dcc2865b8cc0e7932cc5b 100644
--- a/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
+++ b/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
@@ -241,9 +241,8 @@ void ClearBrowsingDataHandler::OnClearingTaskFinished(
UMA_HISTOGRAM_BOOLEAN(
"History.ClearBrowsingData.ShownHistoryNoticeAfterClearing", show_notice);
- ResolveJavascriptCallback(
- base::StringValue(webui_callback_id),
- base::FundamentalValue(show_notice));
+ ResolveJavascriptCallback(base::StringValue(webui_callback_id),
+ base::Value(show_notice));
task_observer_.reset();
}
@@ -273,10 +272,9 @@ void ClearBrowsingDataHandler::OnStateChanged(syncer::SyncService* sync) {
void ClearBrowsingDataHandler::UpdateSyncState() {
CallJavascriptFunction(
- "cr.webUIListenerCallback",
- base::StringValue("update-footer"),
- base::FundamentalValue(sync_service_ && sync_service_->IsSyncActive()),
- base::FundamentalValue(show_history_footer_));
+ "cr.webUIListenerCallback", base::StringValue("update-footer"),
+ base::Value(sync_service_ && sync_service_->IsSyncActive()),
+ base::Value(show_history_footer_));
}
void ClearBrowsingDataHandler::RefreshHistoryNotice() {

Powered by Google App Engine
This is Rietveld 408576698