Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Unified Diff: chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc
diff --git a/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc b/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc
index c35892ff9be84cc85c392eb5534fc6094a67d15a..27173838be4831c2189b2ee33441abbb1e536c39 100644
--- a/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc
+++ b/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc
@@ -162,12 +162,12 @@ void SettingsOverridesAPI::OnExtensionLoaded(
base::MakeUnique<base::StringValue>(SubstituteInstallParam(
settings->homepage->spec(), install_parameter)));
SetPref(extension->id(), prefs::kHomePageIsNewTabPage,
- base::MakeUnique<base::FundamentalValue>(false));
+ base::MakeUnique<base::Value>(false));
}
if (!settings->startup_pages.empty()) {
- SetPref(extension->id(), prefs::kRestoreOnStartup,
- base::MakeUnique<base::FundamentalValue>(
- SessionStartupPref::kPrefValueURLs));
+ SetPref(
+ extension->id(), prefs::kRestoreOnStartup,
+ base::MakeUnique<base::Value>(SessionStartupPref::kPrefValueURLs));
if (settings->startup_pages.size() > 1) {
VLOG(1) << extensions::ErrorUtils::FormatErrorMessage(
kManyStartupPagesWarning,
@@ -185,7 +185,7 @@ void SettingsOverridesAPI::OnExtensionLoaded(
// all search engines.
if (settings->search_engine->is_default) {
SetPref(extension->id(), prefs::kDefaultSearchProviderEnabled,
- base::MakeUnique<base::FundamentalValue>(true));
+ base::MakeUnique<base::Value>(true));
} else {
UnsetPref(extension->id(), prefs::kDefaultSearchProviderEnabled);
}

Powered by Google App Engine
This is Rietveld 408576698