Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4564)

Unified Diff: chrome/browser/extensions/api/settings_private/settings_private_api.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/settings_private/settings_private_api.cc
diff --git a/chrome/browser/extensions/api/settings_private/settings_private_api.cc b/chrome/browser/extensions/api/settings_private/settings_private_api.cc
index 64104da47cbf7a82687851a3f02022dd605293d4..d146a27939314050f7263f3a9a4d139dbdb9a2f9 100644
--- a/chrome/browser/extensions/api/settings_private/settings_private_api.cc
+++ b/chrome/browser/extensions/api/settings_private/settings_private_api.cc
@@ -44,12 +44,10 @@ ExtensionFunction::ResponseAction SettingsPrivateSetPrefFunction::Run() {
delegate->SetPref(parameters->name, parameters->value.get());
switch (result) {
case PrefsUtil::SUCCESS:
- return RespondNow(
- OneArgument(base::MakeUnique<base::FundamentalValue>(true)));
+ return RespondNow(OneArgument(base::MakeUnique<base::Value>(true)));
case PrefsUtil::PREF_NOT_MODIFIABLE:
// Not an error, but return false to indicate setting the pref failed.
- return RespondNow(
- OneArgument(base::MakeUnique<base::FundamentalValue>(false)));
+ return RespondNow(OneArgument(base::MakeUnique<base::Value>(false)));
case PrefsUtil::PREF_NOT_FOUND:
return RespondNow(Error("Pref not found: *", parameters->name));
case PrefsUtil::PREF_TYPE_MISMATCH:
@@ -60,8 +58,7 @@ ExtensionFunction::ResponseAction SettingsPrivateSetPrefFunction::Run() {
parameters->name));
}
NOTREACHED();
- return RespondNow(
- OneArgument(base::MakeUnique<base::FundamentalValue>(false)));
+ return RespondNow(OneArgument(base::MakeUnique<base::Value>(false)));
}
////////////////////////////////////////////////////////////////////////////////
@@ -144,8 +141,7 @@ ExtensionFunction::ResponseAction
return RespondNow(Error(kDelegateIsNull));
delegate->SetDefaultZoom(parameters->zoom);
- return RespondNow(
- OneArgument(base::MakeUnique<base::FundamentalValue>(true)));
+ return RespondNow(OneArgument(base::MakeUnique<base::Value>(true)));
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698