chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc - Issue 2666093002: Remove base::FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/preference/preference_api.cc ('k') | chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc

diff --git a/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc b/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc

index 02e97473912c6358a4e20ed27c12cf80fc0741f8..ea965b08b258cd51e315beb2678348e6291e543b 100644

--- a/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc

+++ b/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc

@@ -56,7 +56,7 @@ ScreenlockPrivateGetLockedFunction::ScreenlockPrivateGetLockedFunction() {}

ScreenlockPrivateGetLockedFunction::~ScreenlockPrivateGetLockedFunction() {}

bool ScreenlockPrivateGetLockedFunction::RunAsync() {

- SetResult(base::MakeUnique<base::FundamentalValue>(

+ SetResult(base::MakeUnique<base::Value>(

proximity_auth::ScreenlockBridge::Get()->IsLocked()));

SendResponse(error_.empty());

return true;

@@ -121,14 +121,14 @@ void ScreenlockPrivateEventRouter::OnScreenDidLock(

proximity_auth::ScreenlockBridge::LockHandler::ScreenType screen_type) {

DispatchEvent(events::SCREENLOCK_PRIVATE_ON_CHANGED,

screenlock::OnChanged::kEventName,

- base::MakeUnique<base::FundamentalValue>(true));

+ base::MakeUnique<base::Value>(true));

}

void ScreenlockPrivateEventRouter::OnScreenDidUnlock(

proximity_auth::ScreenlockBridge::LockHandler::ScreenType screen_type) {

DispatchEvent(events::SCREENLOCK_PRIVATE_ON_CHANGED,

screenlock::OnChanged::kEventName,

- base::MakeUnique<base::FundamentalValue>(false));

+ base::MakeUnique<base::Value>(false));

}

void ScreenlockPrivateEventRouter::OnFocusedUserChanged(