Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1339)

Unified Diff: chrome/browser/extensions/api/preference/preference_api.cc

Issue 2666093002: Remove base::FundamentalValue (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/preference/preference_api.cc
diff --git a/chrome/browser/extensions/api/preference/preference_api.cc b/chrome/browser/extensions/api/preference/preference_api.cc
index 5b0c0ec1be938f0aa436c14051249556bbc2c8ac..5e7b59182cac829426e55df37c023243e6eb98c6 100644
--- a/chrome/browser/extensions/api/preference/preference_api.cc
+++ b/chrome/browser/extensions/api/preference/preference_api.cc
@@ -201,7 +201,7 @@ class InvertBooleanTransformer : public PrefTransformerInterface {
bool bool_value = false;
bool result = value->GetAsBoolean(&bool_value);
DCHECK(result);
- return new base::FundamentalValue(!bool_value);
+ return new base::Value(!bool_value);
}
};
@@ -214,11 +214,9 @@ class NetworkPredictionTransformer : public PrefTransformerInterface {
const bool pref_found = extension_pref->GetAsBoolean(&bool_value);
DCHECK(pref_found) << "Preference not found.";
if (bool_value) {
- return new base::FundamentalValue(
- chrome_browser_net::NETWORK_PREDICTION_DEFAULT);
+ return new base::Value(chrome_browser_net::NETWORK_PREDICTION_DEFAULT);
} else {
- return new base::FundamentalValue(
- chrome_browser_net::NETWORK_PREDICTION_NEVER);
+ return new base::Value(chrome_browser_net::NETWORK_PREDICTION_NEVER);
}
}
@@ -227,8 +225,8 @@ class NetworkPredictionTransformer : public PrefTransformerInterface {
int int_value = chrome_browser_net::NETWORK_PREDICTION_DEFAULT;
const bool pref_found = browser_pref->GetAsInteger(&int_value);
DCHECK(pref_found) << "Preference not found.";
- return new base::FundamentalValue(
- int_value != chrome_browser_net::NETWORK_PREDICTION_NEVER);
+ return new base::Value(int_value !=
+ chrome_browser_net::NETWORK_PREDICTION_NEVER);
}
};

Powered by Google App Engine
This is Rietveld 408576698