third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.h - Issue 2666063003: Continue to process AnalyserNode if inputs are silent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.h

Issue 2666063003: Continue to process AnalyserNode if inputs are silent. (Closed)

Patch Set: Adjust comment per review. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.h

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.h b/third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.h

index e3ccd83ebd699e726a852a8619913086880ea18d..6dbb7081021940a1217a0c59c32d48a313765dbe 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.h

+++ b/third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.h

@@ -50,9 +50,9 @@ class AudioBasicInspectorHandler : public AudioHandler {

void pullInputs(size_t framesToProcess) final;

void checkNumberOfChannelsForInput(AudioNodeInput*) final;

- void updatePullStatus();

+ virtual void updatePullStatus();

- private:

+ protected:

// When setting to true, AudioBasicInspectorHandler will be pulled

// automaticlly by BaseAudioContext before the end of each render quantum.