Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp

Issue 2666063003: Continue to process AnalyserNode if inputs are silent. (Closed)
Patch Set: Adjust comment per review. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp b/third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp
index e1bed1d5e244a4a457395932f14b8f4925d0925d..4ca43d23e01f88ef92f8bcb00e73e08e3931fc82 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp
@@ -116,8 +116,11 @@ void AudioBasicInspectorHandler::updatePullStatus() {
context()->deferredTaskHandler().addAutomaticPullNode(this);
m_needAutomaticPull = true;
} else if (!numberOfInputConnections && m_needAutomaticPull) {
- // The AudioBasicInspectorNode is connected to nothing, remove it from the
- // context's automatic pull list.
+ // The AudioBasicInspectorNode is connected to nothing and is
+ // not an AnalyserNode, remove it from the context's automatic
+ // pull list. AnalyserNode's need to be pulled even with no
+ // inputs so that the internal state gets updated to hold the
+ // right time and FFT data.
context()->deferredTaskHandler().removeAutomaticPullNode(this);
m_needAutomaticPull = false;
}

Powered by Google App Engine
This is Rietveld 408576698