Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.h

Issue 2666063003: Continue to process AnalyserNode if inputs are silent. (Closed)
Patch Set: Adjust comment per review. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012, Intel Corporation. All rights reserved. 2 * Copyright (C) 2012, Intel Corporation. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 public: 43 public:
44 AudioBasicInspectorHandler(NodeType, 44 AudioBasicInspectorHandler(NodeType,
45 AudioNode&, 45 AudioNode&,
46 float sampleRate, 46 float sampleRate,
47 unsigned outputChannelCount); 47 unsigned outputChannelCount);
48 48
49 // AudioHandler 49 // AudioHandler
50 void pullInputs(size_t framesToProcess) final; 50 void pullInputs(size_t framesToProcess) final;
51 void checkNumberOfChannelsForInput(AudioNodeInput*) final; 51 void checkNumberOfChannelsForInput(AudioNodeInput*) final;
52 52
53 void updatePullStatus(); 53 virtual void updatePullStatus();
54 54
55 private: 55 protected:
56 // When setting to true, AudioBasicInspectorHandler will be pulled 56 // When setting to true, AudioBasicInspectorHandler will be pulled
57 // automaticlly by BaseAudioContext before the end of each render quantum. 57 // automaticlly by BaseAudioContext before the end of each render quantum.
58 bool m_needAutomaticPull; 58 bool m_needAutomaticPull;
59 }; 59 };
60 60
61 class AudioBasicInspectorNode : public AudioNode { 61 class AudioBasicInspectorNode : public AudioNode {
62 protected: 62 protected:
63 explicit AudioBasicInspectorNode(BaseAudioContext& context) 63 explicit AudioBasicInspectorNode(BaseAudioContext& context)
64 : AudioNode(context) {} 64 : AudioNode(context) {}
65 65
66 private: 66 private:
67 // TODO(tkent): Should AudioBasicInspectorNode override other variants of 67 // TODO(tkent): Should AudioBasicInspectorNode override other variants of
68 // connect() and disconnect()? 68 // connect() and disconnect()?
69 AudioNode* connect(AudioNode*, 69 AudioNode* connect(AudioNode*,
70 unsigned outputIndex, 70 unsigned outputIndex,
71 unsigned inputIndex, 71 unsigned inputIndex,
72 ExceptionState&) final; 72 ExceptionState&) final;
73 void disconnect(unsigned outputIndex, ExceptionState&) final; 73 void disconnect(unsigned outputIndex, ExceptionState&) final;
74 }; 74 };
75 75
76 } // namespace blink 76 } // namespace blink
77 77
78 #endif // AudioBasicInspectorNode_h 78 #endif // AudioBasicInspectorNode_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698