components/password_manager/core/browser/form_fetcher_impl_unittest.cc - Issue 2666043004: Don't change the HTTPS PasswordForm::action during HTTP -> HTTPS migration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/form_fetcher_impl_unittest.cc

Issue 2666043004: Don't change the HTTPS PasswordForm::action during HTTP -> HTTPS migration. (Closed)

Patch Set: comment Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_manager_browsertest.cc ('k') | components/password_manager/core/browser/http_password_migrator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/form_fetcher_impl_unittest.cc

diff --git a/components/password_manager/core/browser/form_fetcher_impl_unittest.cc b/components/password_manager/core/browser/form_fetcher_impl_unittest.cc

index 9e3e072d82e56a3f20f3641216e781d4c6b9f517..4dd2d5931d820a303b38f94cd9df5b241babbd36 100644

--- a/components/password_manager/core/browser/form_fetcher_impl_unittest.cc

+++ b/components/password_manager/core/browser/form_fetcher_impl_unittest.cc

@@ -490,10 +490,6 @@ TEST_F(FormFetcherImplTest, TryToMigrateHTTPPasswordsOnHTTPSSites) {

form_fetcher_->OnGetPasswordStoreResults(MakeResults(empty_forms));

ASSERT_TRUE(migrator_ptr);

- // Setting action equal to origin is necessary in order to mirror the behavior

- // in HttpPasswordMigrator.

- https_form.action = https_form.origin;

// Now perform the actual migration.

EXPECT_CALL(*mock_store_, AddLogin(https_form));

EXPECT_CALL(*static_cast<MockFormFetcherImpl*>(form_fetcher_.get()),