Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Unified Diff: chrome/browser/resources/settings/internet_page/internet_page.js

Issue 2665913002: MD Settings: Internet: Make detail page layout more robust (Closed)
Patch Set: Feedback Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/internet_page/internet_detail_page.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/internet_page/internet_page.js
diff --git a/chrome/browser/resources/settings/internet_page/internet_page.js b/chrome/browser/resources/settings/internet_page/internet_page.js
index 342bab96e31232b078400d8bb6cf49093da2c8de..8854cbafe2fc7ccd0998497da2243db3034e722e 100644
--- a/chrome/browser/resources/settings/internet_page/internet_page.js
+++ b/chrome/browser/resources/settings/internet_page/internet_page.js
@@ -117,9 +117,12 @@ Polymer({
* @private
*/
onShowDetail_: function(event) {
- settings.navigateTo(
- settings.Route.NETWORK_DETAIL,
- new URLSearchParams('guid=' + event.detail.GUID));
+ var params = new URLSearchParams;
+ params.append('guid', event.detail.GUID);
+ params.append('type', event.detail.Type);
+ if (event.detail.Name)
+ params.append('name', event.detail.Name);
+ settings.navigateTo(settings.Route.NETWORK_DETAIL, params);
},
/**
« no previous file with comments | « chrome/browser/resources/settings/internet_page/internet_detail_page.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698