Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2665753003: Gtk: Remove some unused members of GtkUi (Closed)

Created:
3 years, 10 months ago by Tom (Use chromium acct)
Modified:
3 years, 10 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gtk: Remove some unused members of GtkUi BUG=132847 R=erg@chromium.org Review-Url: https://codereview.chromium.org/2665753003 Cr-Commit-Position: refs/heads/master@{#447329} Committed: https://chromium.googlesource.com/chromium/src/+/2702a3dbb732c51ab72b11c776635286905df1c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -59 lines) Patch
M chrome/browser/ui/libgtkui/gtk_ui.h View 2 chunks +0 lines, -22 lines 0 comments Download
M chrome/browser/ui/libgtkui/gtk_ui.cc View 3 chunks +1 line, -37 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Tom (Use chromium acct)
3 years, 10 months ago (2017-01-30 21:10:20 UTC) #1
Tom (Use chromium acct)
ping. not sure if you saw this one
3 years, 10 months ago (2017-01-31 19:15:13 UTC) #2
Elliot Glaysher
sorry, this one slipped through the cracks. lgtm
3 years, 10 months ago (2017-01-31 20:07:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2665753003/1
3 years, 10 months ago (2017-01-31 20:11:09 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 21:07:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2702a3dbb732c51ab72b11c77663...

Powered by Google App Engine
This is Rietveld 408576698