Gtk: Refactor LoadGtkValues

Gtk: Refactor LoadGtkValues

This CL:
* Removes unused ThemeProperties values like COLOR_NTP_SECTION
* Uses the selection background color as the focus ring color
    * Previously we used the window frame color
    * Now, focused elements like buttons and textareas render with
      an orange ring on Ambiance or a blue ring on Adwaita
* (Gtk3 only) Uses window fg/bg colors for the NTP instead of entry colors
* Reorders stuff in LoadGtkValues

BUG=132847
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2663993002
Cr-Commit-Position: refs/heads/master@{#447410}
Committed: https://chromium.googlesource.com/chromium/src/+/8e02f7a0f2fcf2ce37fc4cd26b98f35f86eb2a9e

[Tom (Use chromium acct), 2017-01-30 23:16:55]

Description was changed from

==========
Gtk: Refactor LoadGtkValues

BUG=132847
R=erg@chromium.org
==========

to

==========
Gtk: Refactor LoadGtkValues

This CL:
* Removes unused ThemeProperties values like COLOR_NTP_SECTION
* Uses the selection background color as the focus ring color
    * Previously we used the window frame color
    * Now, focused elements like buttons and textareas render with
      an orange ring on Ambiance or a blue ring on Adwaita
* (Gtk3 only) Uses window fg/bg colors for the NTP instead of entry colors
* Reorders stuff in LoadGtkValues

BUG=132847
R=erg@chromium.org
==========

[Elliot Glaysher, 2017-01-31 18:30:51]

https://codereview.chromium.org/2663993002/diff/1/chrome/browser/ui/libgtkui/...
File chrome/browser/ui/libgtkui/gtk_ui.cc (left):

https://codereview.chromium.org/2663993002/diff/1/chrome/browser/ui/libgtkui/...
chrome/browser/ui/libgtkui/gtk_ui.cc:890:
colors_[ThemeProperties::COLOR_NTP_SECTION] = toolbar_color;
If these values are actually unusued, you probably want to remove them
everywhere.

[Tom (Use chromium acct), 2017-01-31 18:57:40]

https://codereview.chromium.org/2663993002/diff/1/chrome/browser/ui/libgtkui/...
File chrome/browser/ui/libgtkui/gtk_ui.cc (left):

https://codereview.chromium.org/2663993002/diff/1/chrome/browser/ui/libgtkui/...
chrome/browser/ui/libgtkui/gtk_ui.cc:890:
colors_[ThemeProperties::COLOR_NTP_SECTION] = toolbar_color;
On 2017/01/31 18:30:51, Elliot Glaysher wrote:
> If these values are actually unusued, you probably want to remove them
> everywhere.

sgtm, but maybe that can be done in a different CL?  There's a lot of places
that need to change:

$ git grep COLOR_NTP_SECTION
chrome/browser/themes/browser_theme_pack.cc:  { "ntp_section",
ThemeProperties::COLOR_NTP_SECTION },
chrome/browser/themes/browser_theme_pack.cc:  { "ntp_section_text",
ThemeProperties::COLOR_NTP_SECTION_TEXT },
chrome/browser/themes/browser_theme_pack.cc:  { "ntp_section_link",
ThemeProperties::COLOR_NTP_SECTION_LINK },
chrome/browser/themes/browser_theme_pack.cc:   
ThemeProperties::COLOR_NTP_SECTION_LINK_UNDERLINE },
chrome/browser/themes/browser_theme_pack.cc:     
colors->count(ThemeProperties::COLOR_NTP_SECTION)) {
chrome/browser/themes/browser_theme_pack.cc:       
(*colors)[ThemeProperties::COLOR_NTP_SECTION];
chrome/browser/themes/browser_theme_pack.cc:  if
(!colors->count(ThemeProperties::COLOR_NTP_SECTION_LINK_UNDERLINE) &&
chrome/browser/themes/browser_theme_pack.cc:     
colors->count(ThemeProperties::COLOR_NTP_SECTION_LINK)) {
chrome/browser/themes/browser_theme_pack.cc:       
(*colors)[ThemeProperties::COLOR_NTP_SECTION_LINK];
chrome/browser/themes/browser_theme_pack.cc:   
(*colors)[ThemeProperties::COLOR_NTP_SECTION_LINK_UNDERLINE] =
chrome/browser/themes/browser_theme_pack_unittest.cc: 
colors[ThemeProperties::COLOR_NTP_SECTION_LINK] = link_color;
chrome/browser/themes/browser_theme_pack_unittest.cc: 
colors[ThemeProperties::COLOR_NTP_SECTION_LINK_UNDERLINE] =
chrome/browser/themes/browser_theme_pack_unittest.cc: 
colors[ThemeProperties::COLOR_NTP_SECTION_LINK] = link_color;
chrome/browser/themes/browser_theme_pack_unittest.cc: 
colors[ThemeProperties::COLOR_NTP_SECTION_LINK_UNDERLINE] =
chrome/browser/themes/browser_theme_pack_unittest.cc: 
colors[ThemeProperties::COLOR_NTP_SECTION] = ntp_color;
chrome/browser/themes/browser_theme_pack_unittest.cc: 
colors[ThemeProperties::COLOR_NTP_SECTION] = SkColorSetRGB(190, 190, 190);
chrome/browser/themes/theme_properties.cc:    case COLOR_NTP_SECTION:
chrome/browser/themes/theme_properties.cc:    case COLOR_NTP_SECTION_TEXT:
chrome/browser/themes/theme_properties.cc:    case COLOR_NTP_SECTION_LINK:
chrome/browser/themes/theme_properties.cc:    case
COLOR_NTP_SECTION_LINK_UNDERLINE:
chrome/browser/themes/theme_properties.h:    COLOR_NTP_SECTION,
chrome/browser/themes/theme_properties.h:    COLOR_NTP_SECTION_TEXT,
chrome/browser/themes/theme_properties.h:    COLOR_NTP_SECTION_LINK,
chrome/browser/themes/theme_properties.h:    COLOR_NTP_SECTION_LINK_UNDERLINE,
chrome/browser/themes/theme_properties.h:    COLOR_NTP_SECTION_HEADER_TEXT,
chrome/browser/themes/theme_properties.h:   
COLOR_NTP_SECTION_HEADER_TEXT_HOVER,
chrome/browser/themes/theme_properties.h:    COLOR_NTP_SECTION_HEADER_RULE,
chrome/browser/themes/theme_properties.h:   
COLOR_NTP_SECTION_HEADER_RULE_LIGHT,
chrome/browser/themes/theme_service.cc:    case
ThemeProperties::COLOR_NTP_SECTION_HEADER_TEXT:
chrome/browser/themes/theme_service.cc:    case
ThemeProperties::COLOR_NTP_SECTION_HEADER_TEXT_HOVER:
chrome/browser/themes/theme_service.cc:    case
ThemeProperties::COLOR_NTP_SECTION_HEADER_RULE:
chrome/browser/themes/theme_service.cc:    case
ThemeProperties::COLOR_NTP_SECTION_HEADER_RULE_LIGHT:
chrome/browser/ui/libgtkui/gtk_ui.cc: 
colors_[ThemeProperties::COLOR_NTP_SECTION] = toolbar_color;
chrome/browser/ui/libgtkui/gtk_ui.cc: 
colors_[ThemeProperties::COLOR_NTP_SECTION_TEXT] = label_color;
chrome/browser/ui/libgtkui/gtk_ui.cc: 
colors_[ThemeProperties::COLOR_NTP_SECTION_LINK] = link_color;
chrome/browser/ui/libgtkui/gtk_ui.cc: 
colors_[ThemeProperties::COLOR_NTP_SECTION_LINK_UNDERLINE] = link_color;


$ git grep ntp_section
chrome/browser/themes/browser_theme_pack.cc:  { "ntp_section",
ThemeProperties::COLOR_NTP_SECTION },
chrome/browser/themes/browser_theme_pack.cc:  { "ntp_section_text",
ThemeProperties::COLOR_NTP_SECTION_TEXT },
chrome/browser/themes/browser_theme_pack.cc:  { "ntp_section_link",
ThemeProperties::COLOR_NTP_SECTION_LINK },
chrome/browser/themes/browser_theme_pack.cc:  { "ntp_section_link_underline",
chrome/browser/themes/browser_theme_pack_unittest.cc:                          
"  \"ntp_section_link\": [128, 128, 128] }";
chrome/browser/themes/browser_theme_pack_unittest.cc:                          
"  \"ntp_section_link\": [128, 128, 128],"
chrome/browser/themes/browser_theme_pack_unittest.cc:                          
"  \"ntp_section_link_underline\": [255, 255, 255]"
chrome/browser/themes/browser_theme_pack_unittest.cc:  std::string color_json =
"{ \"ntp_section\": [190, 190, 190] }";
chrome/browser/themes/browser_theme_pack_unittest.cc:                          
"  \"ntp_section\": [190, 190, 190] }";
chrome/common/extensions/docs/templates/articles/themes.html:      "ntp_section"
: [207, 221, 192],
chrome/test/data/extensions/theme/manifest.json:         "ntp_section": [ 207,
221, 192 ],
chrome/test/data/extensions/theme2/manifest.json:         "ntp_section": [ 213,
233, 245 ],
Binary file chrome/test/data/extensions/theme_missing_image.crx matches
chrome/test/data/profiles/profile_with_complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/manifest.json:
        "ntp_section": [ 131, 138, 146, 0.8 ],
chrome/test/data/profiles/profile_with_complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/manifest.json:
        "ntp_section_link": [ 255, 255, 255 ],
chrome/test/data/profiles/profile_with_complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/manifest.json:
        "ntp_section_text": [ 255, 255, 255 ],
chrome/test/data/profiles/profile_with_complex_theme/Default/PreferencesTemplate:
                    "ntp_section": [ 131, 138, 146, 0.8 ],
chrome/test/data/profiles/profile_with_complex_theme/Default/PreferencesTemplate:
                    "ntp_section_link": [ 255, 255, 255 ],
chrome/test/data/profiles/profile_with_complex_theme/Default/PreferencesTemplate:
                    "ntp_section_text": [ 255, 255, 255 ],

[Elliot Glaysher, 2017-01-31 20:05:43]

lgtm if you make a second removal cl

[Tom (Use chromium acct), 2017-01-31 21:27:30]

On 2017/01/31 20:05:43, Elliot Glaysher wrote:
> lgtm if you make a second removal cl

removal cl at https://codereview.chromium.org/2667753004/

I'll try to get approval on that one before I land this cl

[Tom (Use chromium acct), 2017-02-01 00:37:33]

landing because the dependent CL is now under review

[Tom (Use chromium acct), 2017-02-01 00:37:38]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2017-02-01 00:38:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 02:09:53]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485909458607580, "parent_rev":
"5402cd7f4d105ca765798503fa0aecfe69035ca5", "commit_rev":
"8e02f7a0f2fcf2ce37fc4cd26b98f35f86eb2a9e"}

[commit-bot: I haz the power, 2017-02-01 02:14:33]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485909458607580, "parent_rev":
"5402cd7f4d105ca765798503fa0aecfe69035ca5", "commit_rev":
"8e02f7a0f2fcf2ce37fc4cd26b98f35f86eb2a9e"}

[commit-bot: I haz the power, 2017-02-01 02:14:36]

Description was changed from

==========
Gtk: Refactor LoadGtkValues

This CL:
* Removes unused ThemeProperties values like COLOR_NTP_SECTION
* Uses the selection background color as the focus ring color
    * Previously we used the window frame color
    * Now, focused elements like buttons and textareas render with
      an orange ring on Ambiance or a blue ring on Adwaita
* (Gtk3 only) Uses window fg/bg colors for the NTP instead of entry colors
* Reorders stuff in LoadGtkValues

BUG=132847
R=erg@chromium.org
==========

to

==========
Gtk: Refactor LoadGtkValues

This CL:
* Removes unused ThemeProperties values like COLOR_NTP_SECTION
* Uses the selection background color as the focus ring color
    * Previously we used the window frame color
    * Now, focused elements like buttons and textareas render with
      an orange ring on Ambiance or a blue ring on Adwaita
* (Gtk3 only) Uses window fg/bg colors for the NTP instead of entry colors
* Reorders stuff in LoadGtkValues

BUG=132847
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2663993002
Cr-Commit-Position: refs/heads/master@{#447410}
Committed:
https://chromium.googlesource.com/chromium/src/+/8e02f7a0f2fcf2ce37fc4cd26b98...
==========

[commit-bot: I haz the power, 2017-02-01 02:14:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8e02f7a0f2fcf2ce37fc4cd26b98...