Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2665713002: Revert of Temporarily disable context idle cleanup. (Closed)

Created:
3 years, 10 months ago by ericrk
Modified:
3 years, 10 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Temporarily disable context idle cleanup. (patchset #2 id:20001 of https://codereview.chromium.org/2651703004/ ) Reason for revert: Patch was temporary, to check UMA stat changes. Original issue's description: > Temporarily disable context idle cleanup. > > Disables idle cleanup for the worker context to investigate the perf > regression in 664181. > > REVERT BY 01/27/2017 - This is designed to be temporary and measure > the impact of the idle cleanup. > > R=vmpstr > BUG=664181 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2651703004 > Cr-Commit-Position: refs/heads/master@{#446161} > Committed: https://chromium.googlesource.com/chromium/src/+/4c759d5e287eda60b6ce8708ca40a22be6436800 TBR=vmpstr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=664181 Review-Url: https://codereview.chromium.org/2665713002 Cr-Commit-Position: refs/heads/master@{#447004} Committed: https://chromium.googlesource.com/chromium/src/+/2d930bf540c443c992843ab4199af12b2e14848f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M cc/output/context_cache_controller.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M cc/output/context_cache_controller_unittest.cc View 3 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
ericrk
Created Revert of Temporarily disable context idle cleanup.
3 years, 10 months ago (2017-01-30 16:02:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2665713002/1
3 years, 10 months ago (2017-01-30 16:02:57 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 16:59:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2d930bf540c443c992843ab4199a...

Powered by Google App Engine
This is Rietveld 408576698