Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2651703004: Temporarily disable context idle cleanup. (Closed)

Created:
3 years, 11 months ago by ericrk
Modified:
3 years, 11 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily disable context idle cleanup. Disables idle cleanup for the worker context to investigate the perf regression in 664181. REVERT BY 01/27/2017 - This is designed to be temporary and measure the impact of the idle cleanup. R=vmpstr BUG=664181 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2651703004 Cr-Commit-Position: refs/heads/master@{#446161} Committed: https://chromium.googlesource.com/chromium/src/+/4c759d5e287eda60b6ce8708ca40a22be6436800

Patch Set 1 #

Patch Set 2 : Disable unit tests as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M cc/output/context_cache_controller.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M cc/output/context_cache_controller_unittest.cc View 1 3 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
vmpstr
lgtm
3 years, 11 months ago (2017-01-23 21:52:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651703004/1
3 years, 11 months ago (2017-01-23 21:54:50 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/105246)
3 years, 11 months ago (2017-01-23 23:07:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651703004/20001
3 years, 11 months ago (2017-01-25 21:44:29 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/4c759d5e287eda60b6ce8708ca40a22be6436800
3 years, 11 months ago (2017-01-25 23:20:57 UTC) #19
ericrk
3 years, 10 months ago (2017-01-30 16:02:36 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2665713002/ by ericrk@chromium.org.

The reason for reverting is: Patch was temporary, to check UMA stat changes..

Powered by Google App Engine
This is Rietveld 408576698