Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 2665663003: Revert of [Android] Mark infobars as gone when they are off the screen (Closed)

Created:
3 years, 10 months ago by dgn
Modified:
3 years, 10 months ago
Reviewers:
Ted C, Ian Wen
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Mark infobars as gone when they are off the screen (patchset #3 id:40001 of https://codereview.chromium.org/2662613003/ ) Reason for revert: Suspected for causing failures on testers: org.chromium.chrome.browser.infobar.InfoBarContainerTest#testAddAndDismissSurfaceFlingerOverlays (run #2): java.util.concurrent.TimeoutException: InfoBar not added. at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:183) at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:211) at org.chromium.chrome.test.util.InfoBarTestAnimationListener.addInfoBarAnimationFinished(InfoBarTestAnimationListener.java:50) BUG=686734 Original issue's description: > [Android] Mark infobars as gone when they are off the screen > > Infobars are translated off the screen when users scroll up. Yet they > still are thought as non-transparent regions on top of surface view. > This CL optimizes this case by setting the visibility to gone when > infobars are not visible. > > BUG=661560 > > Review-Url: https://codereview.chromium.org/2662613003 > Cr-Commit-Position: refs/heads/master@{#446869} > Committed: https://chromium.googlesource.com/chromium/src/+/45d5cd05e3c01ddbaef79b0d469f34d1c50215f9 TBR=tedchoc@chromium.org,ianwen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=661560 Review-Url: https://codereview.chromium.org/2665663003 Cr-Commit-Position: refs/heads/master@{#446984} Committed: https://chromium.googlesource.com/chromium/src/+/da00ce3b58c2116e88defdf99339ac9b503ceecc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java View 3 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dgn
Created Revert of [Android] Mark infobars as gone when they are off the screen
3 years, 10 months ago (2017-01-30 14:47:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2665663003/1
3 years, 10 months ago (2017-01-30 14:48:02 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 15:22:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/da00ce3b58c2116e88defdf99339...

Powered by Google App Engine
This is Rietveld 408576698