[Android] Mark infobars as gone when they are off the screen

[Android] Mark infobars as gone when they are off the screen

Infobars are translated off the screen when users scroll up. Yet they
still are thought as non-transparent regions on top of surface view.
This CL optimizes this case by setting the visibility to gone when
infobars are not visible.

BUG=661560
Review-Url: https://codereview.chromium.org/2662613003
Cr-Commit-Position: refs/heads/master@{#446869}
Committed: https://chromium.googlesource.com/chromium/src/+/45d5cd05e3c01ddbaef79b0d469f34d1c50215f9

[Ian Wen, 2017-01-27 22:00:02]

ianwen@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Ian Wen, 2017-01-27 22:00:03]

PTAL

[Ted C, 2017-01-27 23:57:14]

lgtm

https://codereview.chromium.org/2662613003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java
(right):

https://codereview.chromium.org/2662613003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java:329:
if (translationY >= getHeight()) {
any reason we pass in translation vs calling getTranslationY() here?

[Ian Wen, 2017-01-28 00:06:25]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2017-01-28 00:06:26]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2662613003/#ps40001
(title: "comments")

[commit-bot: I haz the power, 2017-01-28 00:07:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-28 01:31:09]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485561985822570,
"parent_rev": "588ccce1960c1ca47d65c75f5edb34e5e17d6deb", "commit_rev":
"45d5cd05e3c01ddbaef79b0d469f34d1c50215f9"}

[commit-bot: I haz the power, 2017-01-28 01:31:43]

Description was changed from

==========
[Android] Mark infobars as gone when they are off the screen

Infobars are translated off the screen when users scroll up. Yet they
still are thought as non-transparent regions on top of surface view.
This CL optimizes this case by setting the visibility to gone when
infobars are not visible.

BUG=661560
==========

to

==========
[Android] Mark infobars as gone when they are off the screen

Infobars are translated off the screen when users scroll up. Yet they
still are thought as non-transparent regions on top of surface view.
This CL optimizes this case by setting the visibility to gone when
infobars are not visible.

BUG=661560

Review-Url: https://codereview.chromium.org/2662613003
Cr-Commit-Position: refs/heads/master@{#446869}
Committed:
https://chromium.googlesource.com/chromium/src/+/45d5cd05e3c01ddbaef79b0d469f...
==========

[commit-bot: I haz the power, 2017-01-28 01:31:44]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/45d5cd05e3c01ddbaef79b0d469f...

[dgn, 2017-01-30 14:47:52]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2665663003/ by dgn@chromium.org.

The reason for reverting is: Suspected for causing failures on testers:

org.chromium.chrome.browser.infobar.InfoBarContainerTest#testAddAndDismissSurfaceFlingerOverlays
(run #2):
java.util.concurrent.TimeoutException: InfoBar not added.
	at
org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:183)
	at
org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:211)
	at
org.chromium.chrome.test.util.InfoBarTestAnimationListener.addInfoBarAnimationFinished(InfoBarTestAnimationListener.java:50)

BUG=686734.