Convert ios/web_view to ARC.

Convert ios/web_view to ARC.

BUG=624363
Review-Url: https://codereview.chromium.org/2665653003
Cr-Commit-Position: refs/heads/master@{#447060}
Committed: https://chromium.googlesource.com/chromium/src/+/cb01f2d2b25a91b132ff5371ed8e4718ed26fedf

[michaeldo, 2017-01-30 17:36:42]

michaeldo@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-01-30 17:53:39]

Please use 624363 bug for ARC transitioning CLs. lgtm

https://codereview.chromium.org/2665653003/diff/1/ios/web_view/shell/shell_ap...
File ios/web_view/shell/shell_app_delegate.mm (right):

https://codereview.chromium.org/2665653003/diff/1/ios/web_view/shell/shell_ap...
ios/web_view/shell/shell_app_delegate.mm:35: [[ShellViewController alloc] init];
Do we still need this linebreak?

https://codereview.chromium.org/2665653003/diff/1/ios/web_view/shell/shell_vi...
File ios/web_view/shell/shell_view_controller.mm (right):

https://codereview.chromium.org/2665653003/diff/1/ios/web_view/shell/shell_vi...
ios/web_view/shell/shell_view_controller.mm:21: @property (nonatomic, strong)
UIView* containerView;
Please add comments for properties.

https://codereview.chromium.org/2665653003/diff/1/ios/web_view/shell/translat...
File ios/web_view/shell/translate_controller.mm (right):

https://codereview.chromium.org/2665653003/diff/1/ios/web_view/shell/translat...
ios/web_view/shell/translate_controller.mm:17: @property (nonatomic, strong)
UIAlertController* beforeTranslateActionSheet;
Please add comments.

https://codereview.chromium.org/2665653003/diff/1/ios/web_view/shell/translat...
ios/web_view/shell/translate_controller.mm:49: _beforeTranslateActionSheet =
nil;
nit: self.beforeTranslateActionSheet = nil? Same for other places?

[michaeldo, 2017-01-30 19:29:31]

Description was changed from

==========
Convert ios/web_view to ARC.

BUG=none
==========

to

==========
Convert ios/web_view to ARC.

BUG= 624363
==========

[michaeldo, 2017-01-30 19:30:35]

https://codereview.chromium.org/2665653003/diff/1/ios/web_view/shell/shell_ap...
File ios/web_view/shell/shell_app_delegate.mm (right):

https://codereview.chromium.org/2665653003/diff/1/ios/web_view/shell/shell_ap...
ios/web_view/shell/shell_app_delegate.mm:35: [[ShellViewController alloc] init];
On 2017/01/30 17:53:38, Eugene But wrote:
> Do we still need this linebreak?

Nope, fixed.

https://codereview.chromium.org/2665653003/diff/1/ios/web_view/shell/shell_vi...
File ios/web_view/shell/shell_view_controller.mm (right):

https://codereview.chromium.org/2665653003/diff/1/ios/web_view/shell/shell_vi...
ios/web_view/shell/shell_view_controller.mm:21: @property (nonatomic, strong)
UIView* containerView;
On 2017/01/30 17:53:39, Eugene But wrote:
> Please add comments for properties.

Done.

https://codereview.chromium.org/2665653003/diff/1/ios/web_view/shell/translat...
File ios/web_view/shell/translate_controller.mm (right):

https://codereview.chromium.org/2665653003/diff/1/ios/web_view/shell/translat...
ios/web_view/shell/translate_controller.mm:49: _beforeTranslateActionSheet =
nil;
On 2017/01/30 17:53:39, Eugene But wrote:
> nit: self.beforeTranslateActionSheet = nil? Same for other places?

Done.

[michaeldo, 2017-01-30 19:30:50]

The CQ bit was checked by michaeldo@chromium.org

[michaeldo, 2017-01-30 19:30:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2665653003/#ps20001
(title: "Respond to comments.")

[commit-bot: I haz the power, 2017-01-30 19:31:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 21:07:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485804650136680,
"parent_rev": "44521e985457606bb56e05fbdd45e94bbe3e656f", "commit_rev":
"cb01f2d2b25a91b132ff5371ed8e4718ed26fedf"}

[commit-bot: I haz the power, 2017-01-30 21:07:59]

Description was changed from

==========
Convert ios/web_view to ARC.

BUG= 624363
==========

to

==========
Convert ios/web_view to ARC.

BUG= 624363

Review-Url: https://codereview.chromium.org/2665653003
Cr-Commit-Position: refs/heads/master@{#447060}
Committed:
https://chromium.googlesource.com/chromium/src/+/cb01f2d2b25a91b132ff5371ed8e...
==========

[commit-bot: I haz the power, 2017-01-30 21:08:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cb01f2d2b25a91b132ff5371ed8e...