Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2659393004: Convert ios_web_view_shell to pure Objective-C. (Closed)

Created:
3 years, 10 months ago by michaeldo
Modified:
3 years, 10 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ios_web_view_shell to pure Objective-C. BUG=none Review-Url: https://codereview.chromium.org/2659393004 Cr-Commit-Position: refs/heads/master@{#447141} Committed: https://chromium.googlesource.com/chromium/src/+/8d0b6f3c626a8dc98dbb7fc9097a9c76dcb53bdc

Patch Set 1 #

Patch Set 2 : Move const and format. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -395 lines) Patch
M ios/web_view/shell/BUILD.gn View 1 chunk +5 lines, -5 lines 0 comments Download
A + ios/web_view/shell/shell_app_delegate.m View 1 1 chunk +1 line, -1 line 0 comments Download
D ios/web_view/shell/shell_app_delegate.mm View 1 chunk +0 lines, -56 lines 0 comments Download
A + ios/web_view/shell/shell_delegate.m View 0 chunks +-1 lines, --1 lines 0 comments Download
D ios/web_view/shell/shell_delegate.mm View 1 chunk +0 lines, -17 lines 0 comments Download
A + ios/web_view/shell/shell_exe_main.m View 0 chunks +-1 lines, --1 lines 0 comments Download
D ios/web_view/shell/shell_exe_main.mm View 1 chunk +0 lines, -18 lines 0 comments Download
A + ios/web_view/shell/shell_view_controller.m View 1 2 chunks +8 lines, -10 lines 0 comments Download
D ios/web_view/shell/shell_view_controller.mm View 1 chunk +0 lines, -206 lines 0 comments Download
A + ios/web_view/shell/translate_controller.m View 1 5 chunks +2 lines, -9 lines 0 comments Download
D ios/web_view/shell/translate_controller.mm View 1 chunk +0 lines, -75 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
michaeldo
Note I removed the DCHECKS in translate_controller.m. Is there any reason to add an assert ...
3 years, 10 months ago (2017-01-30 20:46:56 UTC) #2
Eugene But (OOO till 7-30)
lgtm
3 years, 10 months ago (2017-01-30 22:45:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659393004/20001
3 years, 10 months ago (2017-01-30 23:03:24 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 00:51:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8d0b6f3c626a8dc98dbb7fc9097a...

Powered by Google App Engine
This is Rietveld 408576698